Closed Bug 1399375 Opened 7 years ago Closed 7 years ago

Intermittent toolkit/components/extensions/test/xpcshell/test_ext_permissions.js | xpcshell return code: 0

Categories

(WebExtensions :: General, defect)

Product:
WebExtensions
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox57 fixed, firefox58 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla58
Tracking Flags:
Tracking Status
firefox57 --- fixed
firefox58 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: aswan)

References

Details

(Keywords: intermittent-failure, Whiteboard: [stockwell fixed])

Attachments

(1 file)

Bug 1399375 Wait for _uninit in test_ext_permissions.js
59 bytes, text/x-review-board-request
kmag
: review+
Details 
Filed by: archaeopteryx [at] coole-files.de

https://treeherder.mozilla.org/logviewer.html#?job_id=130559257&repo=mozilla-inbound

https://queue.taskcluster.net/v1/task/c-HZiUdnRhyRkmTLA19cNA/runs/0/artifacts/public/logs/live_backing.log

[task 2017-09-13T05:46:44.034556Z] 05:46:44     INFO -  TEST-PASS | xpcshell.ini:toolkit/components/extensions/test/xpcshell/test_ext_permissions.js | test_alreadyGranted - [test_alreadyGranted : 338] Got no permission prompt for already granted optional wildcard origin - false == false
[task 2017-09-13T05:46:44.036423Z] 05:46:44     INFO -  TEST-PASS | xpcshell.ini:toolkit/components/extensions/test/xpcshell/test_ext_permissions.js | test_alreadyGranted - [test_alreadyGranted : 337] request() call succeeded - true == true
[task 2017-09-13T05:46:44.038337Z] 05:46:44     INFO -  TEST-PASS | xpcshell.ini:toolkit/components/extensions/test/xpcshell/test_ext_permissions.js | test_alreadyGranted - [test_alreadyGranted : 338] Got no permission prompt for host matching optional wildcard origin - false == false
[task 2017-09-13T05:46:44.040025Z] 05:46:44     INFO -  PID 14875 | 1505281600858	DeferredSave.webext.sc.lz4	DEBUG	Save changes
[task 2017-09-13T05:46:44.041896Z] 05:46:44     INFO -  PID 14875 | 1505281600859	DeferredSave.webext.sc.lz4	DEBUG	Save changes
[task 2017-09-13T05:46:44.043779Z] 05:46:44     INFO -  PID 14875 | 1505281600860	DeferredSave.webext.sc.lz4	DEBUG	Save changes
[task 2017-09-13T05:46:44.046923Z] 05:46:44     INFO -  PID 14875 | 1505281600860	DeferredSave.webext.sc.lz4	DEBUG	Save changes
[task 2017-09-13T05:46:44.048859Z] 05:46:44     INFO -  "CONSOLE_MESSAGE: (info) 1505281600858	DeferredSave.webext.sc.lz4	DEBUG	Save changes"
[task 2017-09-13T05:46:44.050775Z] 05:46:44     INFO -  "CONSOLE_MESSAGE: (info) 1505281600859	DeferredSave.webext.sc.lz4	DEBUG	Save changes"
[task 2017-09-13T05:46:44.052682Z] 05:46:44     INFO -  "CONSOLE_MESSAGE: (info) 1505281600860	DeferredSave.webext.sc.lz4	DEBUG	Save changes"
[task 2017-09-13T05:46:44.054590Z] 05:46:44     INFO -  "CONSOLE_MESSAGE: (info) 1505281600860	DeferredSave.webext.sc.lz4	DEBUG	Save changes"
[task 2017-09-13T05:46:44.056459Z] 05:46:44     INFO -  (xpcshell/head.js) | test run_next_test 4 pending (2)
[task 2017-09-13T05:46:44.058156Z] 05:46:44     INFO -  (xpcshell/head.js) | test test_alreadyGranted finished (2)
[task 2017-09-13T05:46:44.060191Z] 05:46:44  WARNING -  TEST-UNEXPECTED-FAIL | xpcshell.ini:toolkit/components/extensions/test/xpcshell/test_ext_permissions.js | test_alreadyGranted - [test_alreadyGranted : 265] A promise chain failed to handle a rejection: Unable to arm timer, the object has been finalized. - stack: _do_main@/builds/worker/workspace/build/tests/xpcshell/head.js:221:3
[task 2017-09-13T05:46:44.062054Z] 05:46:44     INFO -  _execute_test@/builds/worker/workspace/build/tests/xpcshell/head.js:544:5
[task 2017-09-13T05:46:44.063699Z] 05:46:44     INFO -  @-e:1:1
[task 2017-09-13T05:46:44.065402Z] 05:46:44     INFO -  Rejection date: Wed Sep 13 2017 05:46:40 GMT+0000 (UTC) - false == true
[task 2017-09-13T05:46:44.067098Z] 05:46:44     INFO -  resource://testing-common/PromiseTestUtils.jsm:assertNoUncaughtRejections:265
[task 2017-09-13T05:46:44.068802Z] 05:46:44     INFO -  /builds/worker/workspace/build/tests/xpcshell/head.js:_run_next_test:1463
[task 2017-09-13T05:46:44.070508Z] 05:46:44     INFO -  /builds/worker/workspace/build/tests/xpcshell/head.js:run:701
[task 2017-09-13T05:46:44.072201Z] 05:46:44     INFO -  /builds/worker/workspace/build/tests/xpcshell/head.js:_do_main:221
[task 2017-09-13T05:46:44.073877Z] 05:46:44     INFO -  /builds/worker/workspace/build/tests/xpcshell/head.js:_execute_test:544
[task 2017-09-13T05:46:44.075442Z] 05:46:44     INFO -  -e:null:1
[task 2017-09-13T05:46:44.077051Z] 05:46:44     INFO -  exiting test
[task 2017-09-13T05:46:44.078728Z] 05:46:44     INFO -  (xpcshell/head.js) | test run_next_test 4 finished (1)
[task 2017-09-13T05:46:44.080309Z] 05:46:44     INFO -  exiting test
103 failures in the last week here:
https://brasstacks.mozilla.com/orangefactor/index.html?display=Bug&bugid=1399375

+66 failures in bug 1399550
See Also: → 1399550
Whiteboard: [stockwell needswork]
See Also: → 1403419
Andrew, I took a look at this, and was able to reproduce a crash on OS X, which is the platform that appears on bug 1403419, whereas this bug is about failures of the same test on Linux. 

For the crash on OS X, I was able to narrow it down to only happening when test_alreadyGranted() is run after test_permissions(). It is reproducible with only those two tests in the file, and is not reproducible without running test_alreadyGranted(), but I don't really see anything in either of those tests that stands out as a possible cause.

This intermittent is failing so often that it is about to be disabled, so do you think you could please take a look at it and see if you can figure out what the problem is?
Assignee: nobody → aswan
Priority: -- → P3
Keywords: leave-open
Disabling on asan really helped - thanks. There are some on-going failures still.
Whiteboard: [stockwell disable-recommended] → [stockwell disabled]
Keywords: leave-open
Attachment #8914564 - Flags: review?(kmaglione+bmo)
The try run linked from reviewboard is for a completely different patch when I was busy barking up the wrong tree.  The actual up-to-date one is:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=da57d73d5877494ae1cd64781b5d8b9d7e4868e3
Comment on attachment 8914564 [details]
Bug 1399375 Wait for _uninit in test_ext_permissions.js

https://reviewboard.mozilla.org/r/185894/#review191212

Wonder if we should try to implement some sort of static analysis for this, the way we do for MOZ_MUST_USE in C++...
Attachment #8914564 - Flags: review?(kmaglione+bmo) → review+
Pushed by aswan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a08c02fa8606
Wait for _uninit in test_ext_permissions.js r=kmag
(In reply to Kris Maglione [:kmag] (long backlog; ping on IRC if you're blocked) from comment #22)
> Wonder if we should try to implement some sort of static analysis for this,
> the way we do for MOZ_MUST_USE in C++...

That would be nice but I assume it would be eslint where that would happen and I don't think eslint would be able to do this in a useful way without some significant work.
(In reply to Andrew Swan [:aswan] from comment #24)
> (In reply to Kris Maglione [:kmag] (long backlog; ping on IRC if you're
> blocked) from comment #22)
> > Wonder if we should try to implement some sort of static analysis for this,
> > the way we do for MOZ_MUST_USE in C++...
> 
> That would be nice but I assume it would be eslint where that would happen
> and I don't think eslint would be able to do this in a useful way without
> some significant work.

We'd probably have to use something like Flow.
https://hg.mozilla.org/mozilla-central/rev/a08c02fa8606
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox58: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
status-firefox57: --- → affected
Whiteboard: [stockwell disabled] → [stockwell fixed]
Is manual testing required on this bug? If yes, please provide some STR and the proper webextension(if required) or set the “qe-verify-“ flag.
Flags: needinfo?(aswan)
No manual testing is required, thanks.
Flags: needinfo?(aswan) → qe-verify-
Product: Toolkit → WebExtensions
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: