Closed Bug 1399379 Opened 3 years ago Closed 3 years ago
Data Verifier::Export Empty Data Summary alignement issue
When trying to start firefox 55 on sparc64 I get: Thread 1 received signal SIGBUS, Bus error. mozilla::dom::SRICheckDataVerifier::ExportEmptyDataSummary (aDataLen=<optimized out>, aData=0x564d0b58 "") at /usr/pkgobj/www/firefox/work/firefox-55.0.3/dom/security/SRICheck.cpp:535 535 *reinterpret_cast<decltype(mHashLength)*>(&aData[offset]) = 0; A *reinterpret_cast<> on the LHS of an assignement almost never is a good idea, as it tricks the compiler to assume proper alignment, which in this case is not guaranteed. A simple temporary var, assign to that and memcpy() is the easy fix.
Hey :francois, :nbp; any chance we can clean up all of those reinterpret casts within SRICheck.cpp? Could anyone of you take on that work?
Priority: -- → P2
I will look at it, in the mean time you can simply remove the only call to this function as it is made for a feature which is not enabled at the moment, but soon will be.
Attachment #8914828 - Flags: review?(francois) → review+
Assignee: nobody → nicolas.b.pierron
Status: NEW → ASSIGNED
Pushed by email@example.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/1fec7f1ae11e Use memcpy to import/export SRI hashes to the JS bytecode buffer. r=francois
You need to log in before you can comment on or make changes to this bug.