[Form Autofill] Add a pref to hide credit card autofill feature

RESOLVED FIXED in Firefox 57

Status

()

enhancement
P1
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: lchang, Assigned: scottwu)

Tracking

(Blocks 1 bug)

unspecified
mozilla57
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(firefox-esr52 unaffected, firefox55 unaffected, firefox56 unaffected, firefox57 fixed)

Details

(Whiteboard: [form autofill:MVP])

Attachments

(1 attachment)

(Reporter)

Description

2 years ago
Before credit card autofill is ready to ship, we should have a pref to hide the credit card feature and only show it on nightly for testing.
Comment hidden (mozreview-request)
(Assignee)

Updated

2 years ago
Assignee: nobody → scwwu
(Reporter)

Comment 2

2 years ago
mozreview-review
Comment on attachment 8907523 [details]
Bug 1399382 - Add a pref to hide credit card autofill feature,

https://reviewboard.mozilla.org/r/179228/#review184820
Attachment #8907523 - Flags: review+
(Reporter)

Comment 3

2 years ago
It occurs to me that we should disable credit-card-related heuristics as well for better performance. I'm thinking we can strip those fields here [1].

[1] https://dxr.mozilla.org/mozilla-central/source/browser/extensions/formautofill/FormAutofillHeuristics.jsm#470-477

Comment 4

2 years ago
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 7aaeb1ef05b5 -d 9f1636ed17b6: rebasing 420007:7aaeb1ef05b5 "Bug 1399382 - Add a pref to hide credit card autofill feature, r=lchang" (tip)
merging browser/app/profile/firefox.js
merging browser/extensions/formautofill/FormAutofillPreferences.jsm
merging browser/extensions/formautofill/test/browser/browser_privacyPreferences.js
warning: conflicts while merging browser/extensions/formautofill/FormAutofillPreferences.jsm! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)
Comment hidden (mozreview-request)

Comment 6

2 years ago
Pushed by lchang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7f7d9a165b2f
Add a pref to hide credit card autofill feature, r=lchang

Comment 7

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/7f7d9a165b2f
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Depends on: 1400395
Do we need this pref on 56? I'm double-checking since I believe we are shipping some part of autofill in 56.
Flags: needinfo?(scwwu)
(Assignee)

Comment 9

2 years ago
Address autofill is shipping on 56, but credit card autofill is not, so we don't need this patch for 56. Thanks Liz.
Flags: needinfo?(scwwu)
You need to log in before you can comment on or make changes to this bug.