1399382 - [Form Autofill] Add a pref to hide credit card autofill feature

Status: RESOLVED FIXED

(Toolkit :: Form Manager, enhancement, P1)

Description

[Luke Chang [:lchang] (inactive)]

Before credit card autofill is ready to ship, we should have a pref to hide the credit card feature and only show it on nightly for testing.

Comment 1

[Scott Wu [:scottwu]]

Attachment: Bug 1399382 - Add a pref to hide credit card autofill feature,

Review commit: https://reviewboard.mozilla.org/r/179228/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/179228/

Comment 2

[Luke Chang [:lchang] (inactive)]

Comment on attachment 8907523 [details]
Bug 1399382 - Add a pref to hide credit card autofill feature,

https://reviewboard.mozilla.org/r/179228/#review184820

Comment 3

[Luke Chang [:lchang] (inactive)]

It occurs to me that we should disable credit-card-related heuristics as well for better performance. I'm thinking we can strip those fields here [1].

[1] https://dxr.mozilla.org/mozilla-central/source/browser/extensions/formautofill/FormAutofillHeuristics.jsm#470-477

Comment 4

[Mozilla Autoland]

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 7aaeb1ef05b5 -d 9f1636ed17b6: rebasing 420007:7aaeb1ef05b5 "Bug 1399382 - Add a pref to hide credit card autofill feature, r=lchang" (tip)
merging browser/app/profile/firefox.js
merging browser/extensions/formautofill/FormAutofillPreferences.jsm
merging browser/extensions/formautofill/test/browser/browser_privacyPreferences.js
warning: conflicts while merging browser/extensions/formautofill/FormAutofillPreferences.jsm! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)

Comment 5

[Scott Wu [:scottwu]]

Comment on attachment 8907523 [details]
Bug 1399382 - Add a pref to hide credit card autofill feature,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/179228/diff/1-2/

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7f7d9a165b2f
Add a pref to hide credit card autofill feature, r=lchang

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/7f7d9a165b2f

Comment 8

[Liz Henry (:lizzard) (relman/hg->git project)]

Do we need this pref on 56? I'm double-checking since I believe we are shipping some part of autofill in 56.

Comment 9

[Scott Wu [:scottwu]]

Address autofill is shipping on 56, but credit card autofill is not, so we don't need this patch for 56. Thanks Liz.