Support code coverage builds on Mac

ASSIGNED
Assigned to

Status

task
ASSIGNED
2 years ago
3 months ago

People

(Reporter: marco, Assigned: marco)

Tracking

(Depends on 2 bugs, Blocks 2 bugs, {leave-open})

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

No description provided.
Assignee: nobody → jyuen1
From bug 1381069 comment 8:
> Update: With the fix in Bug 1409747 (thanks :marco) applied locally to
> latest inbound, my osx ccov build finishes now - but when I startup Firefox
> it errors out with:
> 
> Roberts-MacBook-Pro-1903:mozilla-unified rwood$ ./mach run
>  0:00.69
> /Users/rwood/mozilla-unified/obj-x86_64-apple-darwin16.7.0/dist/NightlyDebug.
> app/Contents/MacOS/firefox -no-remote -foreground -profile
> /Users/rwood/mozilla-unified/obj-x86_64-apple-darwin16.7.0/tmp/scratch_user
> Assertion failure: Storage<T>::initialized(), at
> /Users/rwood/mozilla-unified/obj-x86_64-apple-darwin16.7.0/dist/include/
> mozilla/ThreadLocal.h:225

I'll see if I can reproduce the same crash tomorrow or Friday.
I've managed to get a working build using the following mozconfig:
> ac_add_options --disable-install-strip
> ac_add_options --disable-jemalloc
> ac_add_options --disable-elf-hack
> ac_add_options --enable-debug
> ac_add_options --enable-debug-symbols
> ac_add_options --disable-sandbox
> ac_add_options --enable-coverage
> 
> export CFLAGS="--coverage"
> export CXXFLAGS="--coverage"
> export LDFLAGS="--coverage"

Revision: f7c7cb48610c.
Clang version: Apple LLVM version 9.0.0 (clang-900.0.38).
OS X version: 10.13.
Blocks: 1429455
Assignee: jyuen1 → nobody
Mentor: mcastelluccio
Assignee: nobody → mcastelluccio
Mentor: mcastelluccio
Status: NEW → ASSIGNED
I've tested a build with mochitest-a11y (one of the fastest suites), after applying all patches from the current blocking bugs.
The JavaScript coverage looks sane, the C++ one is still missing a lot of files. I'll try downloading the gcda files from the test machines to figure out what's wrong with the C++ coverage.
(In reply to Marco Castelluccio [:marco] from comment #3)
> I've tested a build with mochitest-a11y (one of the fastest suites), after
> applying all patches from the current blocking bugs.
> The JavaScript coverage looks sane, the C++ one is still missing a lot of
> files. I'll try downloading the gcda files from the test machines to figure
> out what's wrong with the C++ coverage.

Now that all the basic blocking bugs are fixed, I re-tested and both JS and C++ coverage looked fine.
No longer depends on: 1472729
See Also: → 1473541
After we fix bug 1495683, we should start to schedule the build (at least weekly) so we notice regressions earlier.
Attachment #9022242 - Flags: review?(jmaher) → review+
Pushed by mcastelluccio@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0d0fab4a52f7
Run Mac coverage builds on mozilla-central pushes, without running its tests. r=jmaher

The leave-open keyword is there and there is no activity for 6 months.
:marco, maybe it's time to close this bug?

Flags: needinfo?(mcastelluccio)
Flags: needinfo?(mcastelluccio)
Type: defect → task
You need to log in before you can comment on or make changes to this bug.