1399399 - Move internal classes out of RootingAPI.h

Status: RESOLVED FIXED

(Core :: JavaScript: GC, enhancement, P4)

Description

[Jon Coppeard (:jonco)]

There are a few classes defined in the public header RootingAPI.h that are not used outside of the JS engine.  These should be moved to an internal header, possibly gc/Rooting.h.  A quick look shows there are at least the following:

 - FakeRooted
 - FakeMutableHandle
 - MaybeRooted

Comment 1

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Move internal classes out of RootingAPI.h

Comment 2

[Jon Coppeard (:jonco)]

Comment on attachment 8911013 [details] [diff] [review]
Move internal classes out of RootingAPI.h

Review of attachment 8911013 [details] [diff] [review]:
-----------------------------------------------------------------

Great, thanks for the patch!

::: js/src/gc/Rooting.h
@@ +11,5 @@
>  #include "js/RootingAPI.h"
>  
> +#define DELETE_ASSIGNMENT_OPS(Wrapper, T)                                                         \
> +    template <typename S> Wrapper<T>& operator=(S) = delete;                                      \
> +    Wrapper<T>& operator=(const Wrapper<T>&) = delete;

You can just remove the #undef from the end of RootingAPI.h, then you don't need to define/undef it in this file.

Comment 3

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Move internal classes out of RootingAPI.h v2

addressed comment.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9180e59a44f7
Move internal classes out of RootingAPI.h. r=jonco

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/9180e59a44f7