Move internal classes out of RootingAPI.h

RESOLVED FIXED in Firefox 58

Status

()

P4
normal
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: jonco, Assigned: allstars.chh)

Tracking

({good-first-bug})

55 Branch
mozilla58
good-first-bug
Points:
---

Firefox Tracking Flags

(firefox58 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

a year ago
There are a few classes defined in the public header RootingAPI.h that are not used outside of the JS engine.  These should be moved to an internal header, possibly gc/Rooting.h.  A quick look shows there are at least the following:

 - FakeRooted
 - FakeMutableHandle
 - MaybeRooted
Priority: -- → P4
Assignee: nobody → allstars.chh
Created attachment 8911013 [details] [diff] [review]
Move internal classes out of RootingAPI.h
Attachment #8911013 - Flags: review?(jcoppeard)
(Reporter)

Comment 2

a year ago
Comment on attachment 8911013 [details] [diff] [review]
Move internal classes out of RootingAPI.h

Review of attachment 8911013 [details] [diff] [review]:
-----------------------------------------------------------------

Great, thanks for the patch!

::: js/src/gc/Rooting.h
@@ +11,5 @@
>  #include "js/RootingAPI.h"
>  
> +#define DELETE_ASSIGNMENT_OPS(Wrapper, T)                                                         \
> +    template <typename S> Wrapper<T>& operator=(S) = delete;                                      \
> +    Wrapper<T>& operator=(const Wrapper<T>&) = delete;

You can just remove the #undef from the end of RootingAPI.h, then you don't need to define/undef it in this file.
Attachment #8911013 - Flags: review?(jcoppeard) → review+
Created attachment 8911641 [details] [diff] [review]
Move internal classes out of RootingAPI.h v2

addressed comment.
Attachment #8911013 - Attachment is obsolete: true
Attachment #8911641 - Flags: review+

Comment 4

a year ago
Pushed by yhuang@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9180e59a44f7
Move internal classes out of RootingAPI.h. r=jonco
https://hg.mozilla.org/mozilla-central/rev/9180e59a44f7
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox58: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in before you can comment on or make changes to this bug.