Closed Bug 1399399 Opened 4 years ago Closed 4 years ago

Move internal classes out of RootingAPI.h

Categories

(Core :: JavaScript: GC, enhancement, P4)

55 Branch
enhancement

Tracking

()

RESOLVED FIXED
mozilla58
Tracking Status
firefox58 --- fixed

People

(Reporter: jonco, Assigned: allstars.chh)

Details

(Keywords: good-first-bug)

Attachments

(1 file, 1 obsolete file)

There are a few classes defined in the public header RootingAPI.h that are not used outside of the JS engine.  These should be moved to an internal header, possibly gc/Rooting.h.  A quick look shows there are at least the following:

 - FakeRooted
 - FakeMutableHandle
 - MaybeRooted
Priority: -- → P4
Assignee: nobody → allstars.chh
Comment on attachment 8911013 [details] [diff] [review]
Move internal classes out of RootingAPI.h

Review of attachment 8911013 [details] [diff] [review]:
-----------------------------------------------------------------

Great, thanks for the patch!

::: js/src/gc/Rooting.h
@@ +11,5 @@
>  #include "js/RootingAPI.h"
>  
> +#define DELETE_ASSIGNMENT_OPS(Wrapper, T)                                                         \
> +    template <typename S> Wrapper<T>& operator=(S) = delete;                                      \
> +    Wrapper<T>& operator=(const Wrapper<T>&) = delete;

You can just remove the #undef from the end of RootingAPI.h, then you don't need to define/undef it in this file.
Attachment #8911013 - Flags: review?(jcoppeard) → review+
Pushed by yhuang@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9180e59a44f7
Move internal classes out of RootingAPI.h. r=jonco
https://hg.mozilla.org/mozilla-central/rev/9180e59a44f7
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in before you can comment on or make changes to this bug.