If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

[Form Autofill] - "Never Save Credit Cards" text is displayed with small c for credit in the door hanger

VERIFIED FIXED in Firefox 57

Status

()

Toolkit
Form Manager
--
minor
VERIFIED FIXED
8 days ago
7 days ago

People

(Reporter: Gabi Cheta, Assigned: steveck)

Tracking

Trunk
mozilla57
Points:
---

Firefox Tracking Flags

(firefox56 unaffected, firefox57 verified)

Details

(Whiteboard: [form autofill:M4])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

(Reporter)

Description

8 days ago
Created attachment 8907496 [details]
Never Save

[Affected versions]:
57.0a1 20170912220343

[Affected platforms]:
 MacOS 10.12.6, windows 10x64 and Ubuntu 16.04

[Steps to reproduce]:
1. Launch Fx
2. Go to autofill demo page
3. Fill in the form fields with data
4. Hit Submit button
5. Click on the middle arrow on the door hanger to reveal the "Never Save Credit Cards" option

[Expected result]:
"Never Save Credit Card" text should be displayed according to the visual mocks

[Actual result]:
"Never Save credit Cards" text is displayed with small c for credit.


[Regression range]:Not regression

Visual spec: https://mozilla.invisionapp.com/share/7ZA4WEK9W#/screens/215537985

Updated

7 days ago
Whiteboard: [form autofill:M4]

Updated

7 days ago
Flags: needinfo?(schung)
Comment hidden (mozreview-request)
(Assignee)

Updated

7 days ago
Assignee: nobody → schung
Flags: needinfo?(schung)

Comment 2

7 days ago
mozreview-review
Comment on attachment 8907921 [details]
Bug 1399402 - Correct "Never Save Credit Cards" string in the credit card door hanger.

https://reviewboard.mozilla.org/r/179600/#review184782

::: commit-message-a5f16:1
(Diff revision 1)
> +Bug 1399402 -'Never Save Credit Cards' text is displayed with small c for credit in the door hanger. r=lchang

nit: `Correct "Never Save Credit Cards" string in the credit card door hanger`.
Attachment #8907921 - Flags: review?(lchang) → review+
Comment hidden (mozreview-request)
(Assignee)

Comment 4

7 days ago
Thanks!
Keywords: checkin-needed

Updated

7 days ago
status-firefox56: --- → unaffected
Comment hidden (mozreview-request)

Comment 6

7 days ago
Pushed by lchang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1b5b6e3c41fc
Correct "Never Save Credit Cards" string in the credit card door hanger. r=lchang
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/1b5b6e3c41fc
Status: NEW → RESOLVED
Last Resolved: 7 days ago
status-firefox57: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
(Reporter)

Comment 8

7 days ago
Verified issues as fixed with 57.0a1 20170914100122 on Windows 10x64, Ubuntu 16.04 and MacOS 10.12.6
(Reporter)

Updated

7 days ago
Status: RESOLVED → VERIFIED
status-firefox57: fixed → verified
You need to log in before you can comment on or make changes to this bug.