Closed
Bug 1399409
Opened 7 years ago
Closed 7 years ago
fix browser_ext_browserAction_popup_resize.js test failure
Categories
(WebExtensions :: General, defect, P5)
WebExtensions
General
Tracking
(firefox57 fixed)
RESOLVED
FIXED
mozilla57
| Tracking | Status | |
|---|---|---|
| firefox57 | --- | fixed |
People
(Reporter: xeonchen, Assigned: xeonchen)
References
Details
Attachments
(1 file, 1 obsolete file)
|
1.36 KB,
patch
|
kmag
:
review+
|
Details | Diff | Splinter Review |
In bug 1373708, it changes the internal behavior of |AsyncOpen|, where Jar file cache is processed off-main-thread. Some tests are regressed after the patch (attached in this bug) is applied. In this test, got: INFO TEST-UNEXPECTED-FAIL | browser/components/extensions/test/browser/browser_ext_browserAction_popup_resize.js | Uncaught exception - TypeError: content.document.body is null I'm not much familiar with web-extension code, so after investigating for several days, I've decided to make this a separated bug and discuss here.
|
Assignee | |
Comment 1•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a7a84b6e36990aa25935fb11be33826c291fb3aa
Assignee: nobody → xeonchen
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•7 years ago
|
||
(In reply to Gary Chen [:xeonchen] (needinfo plz) from comment #1) > Created attachment 8907960 [details] [diff] [review] > ignore about:blank in awaitBrowserLoaded With bug 1373708: > https://treeherder.mozilla.org/#/jobs?repo=try&revision=a7a84b6e36990aa25935fb11be33826c291fb3aa Without bug 1373708: https://treeherder.mozilla.org/#/jobs?repo=try&revision=36514c362eeec816432a133939a56227761b6ba1
|
|
Assignee | |
Updated•7 years ago
|
Attachment #8907960 -
Flags: review?(kmaglione+bmo)
|
||
Updated•7 years ago
|
Attachment #8907960 -
Flags: review?(kmaglione+bmo) → review+
|
|
Assignee | |
Updated•7 years ago
|
Attachment #8907519 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•7 years ago
|
Keywords: checkin-needed
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/fe4ce395c7ce Ignore about:blank in awaitBrowserLoaded. r=kmag
Keywords: checkin-needed
|
||
Updated•7 years ago
|
status-firefox57:
--- → fix-optional
Priority: -- → P5
|
||
Comment 4•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/fe4ce395c7ce
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
|
||
Comment 5•7 years ago
|
||
Is manual testing required on this bug? If Yes, please provide some STR and the proper webextension(if required), if No set the “qe-verify-“ flag.
Flags: needinfo?(xeonchen)
|
|
Assignee | |
Comment 6•7 years ago
|
||
(In reply to marius.santa from comment #5) > Is manual testing required on this bug? If Yes, please provide some STR and > the proper webextension(if required), if No set the “qe-verify-“ flag. No, thank you :)
Flags: needinfo?(xeonchen) → qe-verify-
|
||
Updated•6 years ago
|
Product: Toolkit → WebExtensions
You need to log in
before you can comment on or make changes to this bug.
Description
•