fix browser_ext_browserAction_popup_resize.js test failure

RESOLVED FIXED in Firefox 57

Status

defect
P5
normal
RESOLVED FIXED
2 years ago
Last year

People

(Reporter: xeonchen, Assigned: xeonchen)

Tracking

unspecified
mozilla57
Points:
---
Dependency tree / graph
Bug Flags:
qe-verify -

Firefox Tracking Flags

(firefox57 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Posted patch bug-1373708-base (obsolete) — Splinter Review
In bug 1373708, it changes the internal behavior of |AsyncOpen|, where Jar file cache is processed off-main-thread.
Some tests are regressed after the patch (attached in this bug) is applied.

In this test, got:
INFO TEST-UNEXPECTED-FAIL | browser/components/extensions/test/browser/browser_ext_browserAction_popup_resize.js | Uncaught exception - TypeError: content.document.body is null                                 

I'm not much familiar with web-extension code, so after investigating for several days, I've decided to make this a separated bug and discuss here.
Attachment #8907960 - Flags: review?(kmaglione+bmo)
Attachment #8907960 - Flags: review?(kmaglione+bmo) → review+
Attachment #8907519 - Attachment is obsolete: true
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fe4ce395c7ce
Ignore about:blank in awaitBrowserLoaded. r=kmag
Keywords: checkin-needed
Priority: -- → P5
https://hg.mozilla.org/mozilla-central/rev/fe4ce395c7ce
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Is manual testing required on this bug? If Yes, please provide some STR and the proper webextension(if required), if No set the “qe-verify-“ flag.
Flags: needinfo?(xeonchen)
(In reply to marius.santa from comment #5)
> Is manual testing required on this bug? If Yes, please provide some STR and
> the proper webextension(if required), if No set the “qe-verify-“ flag.

No, thank you :)
Flags: needinfo?(xeonchen) → qe-verify-
Product: Toolkit → WebExtensions
You need to log in before you can comment on or make changes to this bug.