Closed
Bug 1399418
Opened 7 years ago
Closed 7 years ago
JS::ContextOptions::ContextOptions(): missing initialisations
Categories
(Core :: JavaScript Engine, defect, P2)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla57
Tracking | Status | |
---|---|---|
firefox57 | --- | fixed |
People
(Reporter: jseward, Assigned: jseward)
Details
Attachments
(2 files)
4.31 KB,
text/plain
|
Details | |
725 bytes,
patch
|
till
:
review+
|
Details | Diff | Splinter Review |
(in js/src/jsapi.h) JS::ContextOptions::ContextOptions() lacks initialisations for |streams_| and |fuzzing_|. At least the uninitialisedness of |streams_| is easily seen when running Mochitests on Valgrind.
Assignee | ||
Comment 1•7 years ago
|
||
Assignee | ||
Comment 2•7 years ago
|
||
This initialises |streams_| and also |fuzzing_| to be on the safe side.
Comment 3•7 years ago
|
||
Comment on attachment 8907529 [details] [diff] [review] Add missing initialisations Review of attachment 8907529 [details] [diff] [review]: ----------------------------------------------------------------- I know you didn't ask for review, but still, rs=me
Attachment #8907529 -
Flags: review+
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → jseward
Pushed by jseward@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/4951f14df00c JS::ContextOptions::ContextOptions(): missing initialisations. r=till.
Updated•7 years ago
|
status-firefox57:
--- → affected
Priority: -- → P2
Comment 5•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/4951f14df00c
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in
before you can comment on or make changes to this bug.
Description
•