Closed Bug 1399421 Opened 7 years ago Closed 7 years ago

Suggested language improvements on onboarding screens

Categories

(Firefox :: New Tab Page, enhancement, P3)

Product:
Firefox
Component:
New Tab Page
Version:
57 Branch
Type:
enhancement

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 57
Tracking Flags:
Tracking Status
firefox57 --- verified
firefox58 --- verified

People

(Reporter: abovens, Assigned: gasolin)

Details

(Whiteboard: [photon-onboarding])

Attachments

(1 file)

Bug 1399421 - change onboarding library description;
59 bytes, text/x-review-board-request
Fischer
: review+
Details 
In the "Performance" section:
"the best Nightly yet." -> "the best Nightly yet!" (to convey more enthusiasm)

In the "Library" section:
"-" (dash) -> "—" (emdash)
"Pocket lists" -> "Pocket list" (there's only one list in Pocket, afaik)

In the "Sync" section:
There is no mention of the Firefox Account settings here, which is where the Sync settings can be found. Maybe there should be a button linking to the relevant Setting and/or update the text to make this more clear?

Note aside: I've noticed that I'm getting the en-US version of the onboarding screens, rather than the en-GB version. ("Customize" rather than "Customise"). Is this a bug, or haven't we finished translating everything yet?
Component: Foxfooding → New Tab Page
Flags: needinfo?(mverdi)
Given that we're past the deadline for localization...

(In reply to Andreas Bovens from comment #0)
> In the "Performance" section:
> "the best Nightly yet." -> "the best Nightly yet!" (to convey more
> enthusiasm)
> 

I think we can go with Michelle's original here. We've tested these and they hit intended tone.

> 
> In the "Sync" section:
> There is no mention of the Firefox Account settings here, which is where the
> Sync settings can be found. Maybe there should be a button linking to the
> relevant Setting and/or update the text to make this more clear?

This is a suggestion we should investigate post 57 but the current sync setup flow has you choose what to sync and then takes you to the settings at the end. 

> 
> Note aside: I've noticed that I'm getting the en-US version of the
> onboarding screens, rather than the en-GB version. ("Customize" rather than
> "Customise"). Is this a bug, or haven't we finished translating everything
> yet?

I would think this just hasn't been localized yet.

> In the "Library" section:
> "-" (dash) -> "—" (emdash)
> "Pocket lists" -> "Pocket list" (there's only one list in Pocket, afaik)

These two look like mistakes. Fred is it possible to fix these in 57?
Flags: needinfo?(mverdi) → needinfo?(gasolin)
> > In the "Library" section:
> > "-" (dash) -> "—" (emdash)
> > "Pocket lists" -> "Pocket list" (there's only one list in Pocket, afaik)
> 
> These two look like mistakes. Fred is it possible to fix these in 57?

localize process are start in beta stage, so we can fix these strings in 57
Flags: needinfo?(gasolin) → qe-verify+
Priority: -- → P3
Whiteboard: [photon-onboarding][triage] → [photon-onboarding]
Assignee: nobody → gasolin
Status: NEW → ASSIGNED
Comment on attachment 8908554 [details]
Bug 1399421 - change onboarding library description;

https://reviewboard.mozilla.org/r/180220/#review185368

::: browser/extensions/onboarding/locales/en-US/onboarding.properties:98
(Diff revision 1)
>  onboarding.notification.onboarding-tour-sync.message=Still sending yourself links to save or read on your phone? Do it the easy way: get Sync and have the things you save here show up on all of your devices.
>  
>  onboarding.tour-library=Library
>  onboarding.tour-library.title=Keep it together.
>  # LOCALIZATION NOTE (onboarding.tour-library.description): This string will be used in the library tour description. %1$S is brandShortName
> -onboarding.tour-library.description=Check out the new %1$S library in the redesigned toolbar. The library puts the things you’ve seen and saved to %1$S - your browsing history, bookmarks, Pocket lists, and synced tabs - in one convenient place.
> +onboarding.tour-library.description2=Check out the new %1$S library in the redesigned toolbar. The library puts the things you’ve seen and saved to %1$S — your browsing history, bookmarks, Pocket list, and synced tabs - in one convenient place.

No need to change the string ID, it's a typographical convention for English, other language have their own.
(In reply to Fred Lin [:gasolin] from comment #2)
> > > In the "Library" section:
> > > "-" (dash) -> "—" (emdash)
> > > "Pocket lists" -> "Pocket list" (there's only one list in Pocket, afaik)
> > 
> > These two look like mistakes. Fred is it possible to fix these in 57?
> 
> localize process are start in beta stage, so we can fix these strings in 57

I have no clue where you got that, but no, localization happens on Nightly.
Comment on attachment 8908554 [details]
Bug 1399421 - change onboarding library description;

https://reviewboard.mozilla.org/r/180220/#review185370

::: browser/extensions/onboarding/locales/en-US/onboarding.properties:98
(Diff revision 2)
>  onboarding.notification.onboarding-tour-sync.message=Still sending yourself links to save or read on your phone? Do it the easy way: get Sync and have the things you save here show up on all of your devices.
>  
>  onboarding.tour-library=Library
>  onboarding.tour-library.title=Keep it together.
>  # LOCALIZATION NOTE (onboarding.tour-library.description): This string will be used in the library tour description. %1$S is brandShortName
> -onboarding.tour-library.description=Check out the new %1$S library in the redesigned toolbar. The library puts the things you’ve seen and saved to %1$S - your browsing history, bookmarks, Pocket lists, and synced tabs - in one convenient place.
> +onboarding.tour-library.description2=Check out the new %1$S library in the redesigned toolbar. The library puts the things you’ve seen and saved to %1$S — your browsing history, bookmarks, Pocket list, and synced tabs — in one convenient place.

Sorry, I completely missed the change "Pocket lists" to "Pocket list". We need the new ID in the end :-\

(you also didn't update the code part)
Comment on attachment 8908554 [details]
Bug 1399421 - change onboarding library description;

https://reviewboard.mozilla.org/r/180220/#review185372
Attachment #8908554 - Flags: review?(fliu) → review+
Comment on attachment 8908554 [details]
Bug 1399421 - change onboarding library description;

https://reviewboard.mozilla.org/r/180220/#review185376

::: browser/extensions/onboarding/locales/en-US/onboarding.properties:97
(Diff revision 2)
>  onboarding.notification.onboarding-tour-sync.title=Pick up where you left off.
>  onboarding.notification.onboarding-tour-sync.message=Still sending yourself links to save or read on your phone? Do it the easy way: get Sync and have the things you save here show up on all of your devices.
>  
>  onboarding.tour-library=Library
>  onboarding.tour-library.title=Keep it together.
>  # LOCALIZATION NOTE (onboarding.tour-library.description): This string will be used in the library tour description. %1$S is brandShortName

nit: update the localization comment reference
(In reply to Andreas Bovens from comment #0)
> Note aside: I've noticed that I'm getting the en-US version of the
> onboarding screens, rather than the en-GB version. ("Customize" rather than
> "Customise"). Is this a bug, or haven't we finished translating everything
> yet?

en-GB is sadly behind with localization, so it's expected. I'm sure they wouldn't mind some help (@ian)
https://wiki.mozilla.org/L10n:Teams:en-GB
Comment on attachment 8908554 [details]
Bug 1399421 - change onboarding library description;

https://reviewboard.mozilla.org/r/180220/#review185376

> nit: update the localization comment reference

Thanks for catch that and thanks for the locale timing update.
Pushed by flin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5c947934d285
change onboarding library description;r=Fischer
either the string can catch up with v57 or not, we should fix it in nightly
https://hg.mozilla.org/mozilla-central/rev/5c947934d285
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox57: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
I have verified that the Suggested language improvements on onboarding screens on Win 10 x64, Win 7 x32, Ubuntu 16.04 x32, and Mac 10.12 with Firefox 58.
status-firefox58: --- → verified
Leaving aside the "!" from the Performance section, I can confirm this issue is fixed on Fx 57.0b7.
Status: RESOLVED → VERIFIED
status-firefox57: fixed → verified
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: