Closed
Bug 1399456
Opened 7 years ago
Closed 7 years ago
Clean up aboutTelemetry.properties
Categories
(Toolkit :: Telemetry, enhancement)
Toolkit
Telemetry
Tracking
()
RESOLVED
FIXED
mozilla57
Tracking | Status | |
---|---|---|
firefox57 | --- | fixed |
People
(Reporter: chutten, Assigned: flod)
References
Details
Attachments
(1 file)
toolkit/locales/en-US/chrome/global/aboutTelemetry.properties doesn't look like other properties files and could use a good tidying.
Assignee | ||
Comment 1•7 years ago
|
||
For reference: http://searchfox.org/mozilla-central/rev/e76c0fee79a34a3612740b33508276f4b37c3ee8/toolkit/locales/en-US/chrome/global/aboutTelemetry.properties There are a few steps here, and it's basically what I did for aboutTelemetry.dtd recently: 1) Reorganize the strings in a more logical order, for example grouping together strings that appear together in the UI. 2) Avoid unnecessary blank lines. It's OK to separate a group of keys, not great to have a blank line after every key. 3) Use the common format for localization comments https://developer.mozilla.org/en-US/docs/Mozilla/Localization/Localization_content_best_practices#Add_localization_notes #1 also helps finding unused strings, add comments where strings could benefit from one, and identify localization issues. I'm happy to give it a pass.
Assignee: nobody → francesco.lodolo
Assignee | ||
Comment 2•7 years ago
|
||
Seem unused: * chrome-hangs-title * captured-stacks-title * late-writes-title
Assignee | ||
Comment 3•7 years ago
|
||
(In reply to Francesco Lodolo [:flod] from comment #2) > Seem unused: > * chrome-hangs-title > * captured-stacks-title > * late-writes-title Never mind, the string ID is generated automatically (from bug 838164).
Comment hidden (mozreview-request) |
Assignee | ||
Comment 5•7 years ago
|
||
There are no removed strings, only reordering and comment format. I double checked in Atom by ordering lines alphabetically, removing empty lines and comments, and comparing file content before and after. I didn't find any unused string, but a few issues (filing as blocked by this bug).
Reporter | ||
Comment 6•7 years ago
|
||
mozreview-review |
Comment on attachment 8907963 [details] Bug 1399456 - Clean up aboutTelemetry.properties (reorganize content, comments format) https://reviewboard.mozilla.org/r/179630/#review184998 Consistency is reason enough. Thank you for your efforts!
Attachment #8907963 -
Flags: review?(chutten) → review+
Pushed by francesco.lodolo@mozillaitalia.org: https://hg.mozilla.org/integration/autoland/rev/18a13126bd54 Clean up aboutTelemetry.properties (reorganize content, comments format) r=chutten
Comment 8•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/18a13126bd54
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Comment 9•7 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/18a13126bd54 > -# Note to translators: > -# - %1$S will be replaced by brandFullName > -# - %2$S will be replaced with the value of the toolkit.telemetry.server_owner preference > +# LOCALIZATION NOTE(pageSubtitle): > +# - %1$S is replaced by brandFullName > +# - %2$S is replaced by the value of the toolkit.telemetry.server_owner preference > pageSubtitle = This page shows the information about performance, hardware, usage and customizations collected by Telemetry. This information is submitted to %1$S to help improve %2$S. Is it only me or placeholders should be reverted?
Assignee | ||
Comment 10•7 years ago
|
||
Indeed, I reformatted the existing comment and didn't notice they were inverted. http://searchfox.org/mozilla-central/rev/31606bbabc50b08895d843b9f5f3da938ccdfbbf/toolkit/content/aboutTelemetry.js#1845
You need to log in
before you can comment on or make changes to this bug.
Description
•