1399457 - brandShortName should remain short for 'Firefox Nightly'

Status: RESOLVED INVALID

(Firefox :: General, defect)

Description

[Sylvestre Ledru [:Sylvestre]]

See https://bugzilla.mozilla.org/show_bug.cgi?id=1378834#c23

Comment 1

[Sylvestre Ledru [:Sylvestre]]

1378834 has been backout, I will do it there.

Comment 2

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1399457 - Change brandShortName to Nightly instead of brandShortName

Review commit: https://reviewboard.mozilla.org/r/185420/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/185420/

Comment 3

[Dão Gottwald [:dao]]

Comment on attachment 8914028 [details]
Bug 1399457 - Change brandShortName to Nightly instead of brandShortName

https://reviewboard.mozilla.org/r/185420/#review190340

Also need to update brand.dtd

Comment 4

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8914028 [details]
Bug 1399457 - Change brandShortName to Nightly instead of brandShortName

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/185420/diff/1-2/

Comment 5

[Dão Gottwald [:dao]]

Comment on attachment 8914028 [details]
Bug 1399457 - Change brandShortName to Nightly instead of brandShortName

https://reviewboard.mozilla.org/r/185420/#review191036

Comment 6

[Sylvestre Ledru [:Sylvestre]]

https://hg.mozilla.org/projects/oak/rev/698c34fb4e3a80f6b2413ecd8ecae88d0ff97185
Bug 1399457 - Change brandShortName to Nightly instead of brandShortName r?dao

Comment 7

[Sylvestre Ledru [:Sylvestre]]

I updated bug 1378834 to include the change.
It doesn't really make sense to keep them separated.

Comment 8

[Sylvestre Ledru [:Sylvestre]]

https://hg.mozilla.org/projects/oak/rev/d2efaf1a147c0c858190d49e29202ce0cf426d2c
Bug 1399457 - Generate a build with 'Firefox Nightly' as short name so that Adrian from QE can compare a=oak