Closed Bug 1399466 Opened 2 years ago Closed 2 years ago

IPCBlobInputStream should not use STS to read from the remote Stream, but DOMFile thread instead.

Categories

(Core :: DOM: File, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla58
Tracking Status
firefox58 --- fixed

People

(Reporter: baku, Assigned: baku)

References

Details

Attachments

(1 file, 1 obsolete file)

No description provided.
Attached patch deadlock2.patch (obsolete) — Splinter Review
Attachment #8907586 - Flags: review?(bugs)
Attachment #8907586 - Flags: review?(bugs) → review+
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/393e901c47f6
IPCBlobInputStream should not use STS to read from the remote Stream, but DOMFile thread instead, r=smaug
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7822d49cfd59
IPCBlobInputStream should not use STS to read from the remote Stream, but DOMFile thread instead, r=smaug
https://hg.mozilla.org/mozilla-central/rev/7822d49cfd59
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Flags: needinfo?(amarchesini)
Backed out for frequent leaks on Linux x64 debug (bug 1400132) and on Linux x64 asan (bug 1399117):

https://hg.mozilla.org/integration/mozilla-inbound/rev/f39e7ce332c0fd66c0c05e44684daa53f70bcaac

bug 1399117 on Treeherder: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&tochange=a36c26e1b55ec712213506c015802625834758af&fromchange=6777be860609e4149d9ffa73b8dc6f1beadfbd5d&filter-searchStr=Linux%20x64%20asan%20M-e10s%283%29&selectedJob=131456136
> TEST-UNEXPECTED-FAIL | LeakSanitizer | leak at nsBaseChannel::SetContentDispositionFilename, nsBaseChannel::SetContentDispositionFilename, nsHostObjectProtocolHandler::NewChannel2

bug 1400132 on Treeherder: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&filter-searchStr=Linux%20x64%20debug%20M-e10s%283%29&tochange=ea39b11826c9f4299ae84231d76a97abecbf9747&fromchange=21edf7e4f6adee7c85cef2e5827bc5431a62d7e6&selectedJob=131462704
> TEST-UNEXPECTED-FAIL | leakcheck | tab process: 13520 bytes leaked (ChannelMediaResource::Listener, HTMLMediaElement::MediaLoadListener, IPCBlobInputStream, LoadInfo, RequestContext, ...)
Status: RESOLVED → REOPENED
Flags: needinfo?(amarchesini)
Resolution: FIXED → ---
Target Milestone: mozilla57 → ---
Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/mozilla-inbound/rev/007288c8b751
Remove duplicate interface definition which caused bustage. r=bustage-fix on a CLOSED TREE
Attached patch aa.patchSplinter Review
smaug, I need you to review the IPCBlobInputStreamThread part again.
The previous patch was making ASAN build unhappy. The solution was to make IPCBlobInputStreamThread a nsIEventTarget and check when exec ::Dispatch().
Attachment #8907586 - Attachment is obsolete: true
Flags: needinfo?(amarchesini)
Attachment #8912197 - Flags: review?(bugs)
Attachment #8912197 - Flags: review?(bugs) → review+
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/075e7eef53f4
IPCBlobInputStream should not use STS to read from the remote Stream, but DOMFile thread instead, r=smaug
https://hg.mozilla.org/mozilla-central/rev/075e7eef53f4
Status: REOPENED → RESOLVED
Closed: 2 years ago2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
Depends on: 1450302
You need to log in before you can comment on or make changes to this bug.