Closed
Bug 1399466
Opened 7 years ago
Closed 7 years ago
IPCBlobInputStream should not use STS to read from the remote Stream, but DOMFile thread instead.
Categories
(Core :: DOM: File, enhancement)
Core
DOM: File
Tracking
()
RESOLVED
FIXED
mozilla58
Tracking | Status | |
---|---|---|
firefox58 | --- | fixed |
People
(Reporter: baku, Assigned: baku)
References
Details
Attachments
(1 file, 1 obsolete file)
11.13 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•7 years ago
|
||
Attachment #8907586 -
Flags: review?(bugs)
Updated•7 years ago
|
Attachment #8907586 -
Flags: review?(bugs) → review+
Pushed by amarchesini@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/393e901c47f6 IPCBlobInputStream should not use STS to read from the remote Stream, but DOMFile thread instead, r=smaug
Comment 3•7 years ago
|
||
Backed out so bug 1398556 can be backed out: https://hg.mozilla.org/integration/mozilla-inbound/rev/a011200d3c85de865781a68aac3fd5ab47d2bfd4
Flags: needinfo?(amarchesini)
Pushed by amarchesini@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/7822d49cfd59 IPCBlobInputStream should not use STS to read from the remote Stream, but DOMFile thread instead, r=smaug
Comment 5•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/7822d49cfd59
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Assignee | ||
Updated•7 years ago
|
Flags: needinfo?(amarchesini)
Comment 6•7 years ago
|
||
Backed out for frequent leaks on Linux x64 debug (bug 1400132) and on Linux x64 asan (bug 1399117): https://hg.mozilla.org/integration/mozilla-inbound/rev/f39e7ce332c0fd66c0c05e44684daa53f70bcaac bug 1399117 on Treeherder: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&tochange=a36c26e1b55ec712213506c015802625834758af&fromchange=6777be860609e4149d9ffa73b8dc6f1beadfbd5d&filter-searchStr=Linux%20x64%20asan%20M-e10s%283%29&selectedJob=131456136 > TEST-UNEXPECTED-FAIL | LeakSanitizer | leak at nsBaseChannel::SetContentDispositionFilename, nsBaseChannel::SetContentDispositionFilename, nsHostObjectProtocolHandler::NewChannel2 bug 1400132 on Treeherder: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&filter-searchStr=Linux%20x64%20debug%20M-e10s%283%29&tochange=ea39b11826c9f4299ae84231d76a97abecbf9747&fromchange=21edf7e4f6adee7c85cef2e5827bc5431a62d7e6&selectedJob=131462704 > TEST-UNEXPECTED-FAIL | leakcheck | tab process: 13520 bytes leaked (ChannelMediaResource::Listener, HTMLMediaElement::MediaLoadListener, IPCBlobInputStream, LoadInfo, RequestContext, ...)
Status: RESOLVED → REOPENED
status-firefox57:
fixed → ---
Flags: needinfo?(amarchesini)
Resolution: FIXED → ---
Target Milestone: mozilla57 → ---
Pushed by archaeopteryx@coole-files.de: https://hg.mozilla.org/integration/mozilla-inbound/rev/007288c8b751 Remove duplicate interface definition which caused bustage. r=bustage-fix on a CLOSED TREE
Assignee | ||
Comment 9•7 years ago
|
||
smaug, I need you to review the IPCBlobInputStreamThread part again. The previous patch was making ASAN build unhappy. The solution was to make IPCBlobInputStreamThread a nsIEventTarget and check when exec ::Dispatch().
Attachment #8907586 -
Attachment is obsolete: true
Flags: needinfo?(amarchesini)
Attachment #8912197 -
Flags: review?(bugs)
Updated•7 years ago
|
Attachment #8912197 -
Flags: review?(bugs) → review+
Comment 10•7 years ago
|
||
Pushed by amarchesini@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/075e7eef53f4 IPCBlobInputStream should not use STS to read from the remote Stream, but DOMFile thread instead, r=smaug
Comment 11•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/075e7eef53f4
Status: REOPENED → RESOLVED
Closed: 7 years ago → 7 years ago
status-firefox58:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in
before you can comment on or make changes to this bug.
Description
•