Closed
Bug 1399468
Opened 7 years ago
Closed 7 years ago
Update remaining tests within dom/browser-element to comply with new toplevel data: URI navigation policy
Categories
(Core :: DOM: Security, enhancement)
Core
DOM: Security
Tracking
()
RESOLVED
FIXED
mozilla57
Tracking | Status | |
---|---|---|
firefox57 | --- | fixed |
People
(Reporter: ckerschb, Assigned: ckerschb)
References
Details
(Whiteboard: [domsecurity-active])
Attachments
(1 file)
3.82 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•7 years ago
|
||
Total there are 129 tests that start with: dom/browser-element/mochitest/test_browserElement_* Locally running all of them using: ./mach test dom/browser-element/mochitest/ does not return a single error. When pushing to TRY [1] I get some errors on Android. Then running those tests locally, e.g. ./mach test dom/browser-element/mochitest/test_browserElement_inproc_Iconchange.html the tests fails locally :-) [1] https://treeherder.mozilla.org/#/jobs?repo=try&revision=e0a270e662d0d54dc0838afe23d00aa6d5ca6939&selectedJob=130432293
Assignee | ||
Updated•7 years ago
|
Summary: Update remaining tests within dom/browser-element to comply with new toplevel data: URI navigation policy See dependency tree for bug 1399074 → Update remaining tests within dom/browser-element to comply with new toplevel data: URI navigation policy
Assignee | ||
Comment 2•7 years ago
|
||
Smaug, any chance you could review those four test updates: * dom/browser-element/mochitest/test_browserElement_inproc_Iconchange.html * dom/browser-element/mochitest/test_browserElement_inproc_Manifestchange.html * dom/browser-element/mochitest/test_browserElement_inproc_Metachange.html * dom/browser-element/mochitest/test_browserElement_inproc_Opensearch.html Please see previous comment why I wasn't able to incorporate those changes the first time around when you reviewed Bug 1399074 and we added allowTopLevelDataURINavigation, see: https://hg.mozilla.org/mozilla-central/rev/be5bcc9e9657#l1.13
Attachment #8907610 -
Flags: review?(bugs)
Comment 3•7 years ago
|
||
Comment on attachment 8907610 [details] [diff] [review] bug_1399468_reaming_dom_tests.patch rs+ (but we still need some data: tests for mozbrowser)
Attachment #8907610 -
Flags: review?(bugs) → review+
Pushed by mozilla@christophkerschbaumer.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/fa8b67b47624 Update remaining tests within dom/browser-element to comply with new toplevel data: URI navigation policy. r=smaug
Assignee | ||
Comment 5•7 years ago
|
||
(In reply to Olli Pettay [:smaug] (Currently reviews only for patches which should land to FF57 [2017-09-21]) from comment #3) > (but we still need some data: tests for mozbrowser) Working on it, see Bug 1399170.
Comment 6•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/fa8b67b47624
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in
before you can comment on or make changes to this bug.
Description
•