Closed
Bug 1399489
Opened 7 years ago
Closed 7 years ago
CanvasLayer::CanvasLayer(LayerManager*, void*): missing initialisations
Categories
(Core :: Graphics: Layers, enhancement, P3)
Core
Graphics: Layers
Tracking
()
RESOLVED
FIXED
mozilla57
People
(Reporter: jseward, Assigned: jseward)
Details
(Whiteboard: [gfx-noted])
Attachments
(2 files)
7.62 KB,
text/plain
|
Details | |
589 bytes,
patch
|
nical
:
review+
|
Details | Diff | Splinter Review |
CanvasLayer::CanvasLayer(LayerManager*, void*) lacks an initialisation for CanvasLayer::mSamplingFilter. This is seen fairly readily when running Mochitests on Valgrind. In particular, CanvasLayer::SetSamplingFilter() compares its argument against the uninitialised mSamplingFilter. One effect is that the call to Mutated() may randomly be omitted, if the garbage mSamplingFilter value happens to be the same as aSamplingFilter.
Assignee | ||
Comment 1•7 years ago
|
||
Assignee | ||
Comment 2•7 years ago
|
||
Test path = dom/canvas/test/webgl-conf/generated
Assignee | ||
Comment 3•7 years ago
|
||
Attachment #8907619 -
Flags: review?(nical.bugzilla)
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → jseward
Updated•7 years ago
|
status-firefox55:
--- → wontfix
status-firefox56:
--- → wontfix
status-firefox57:
--- → affected
status-firefox-esr52:
--- → wontfix
Priority: -- → P3
Whiteboard: [gfx-noted]
Updated•7 years ago
|
Attachment #8907619 -
Flags: review?(nical.bugzilla) → review+
Pushed by jseward@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/dffc040eb2f8 CanvasLayer::CanvasLayer(LayerManager*, void*): missing initialisations. r=nical.
Comment 5•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/dffc040eb2f8
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in
before you can comment on or make changes to this bug.
Description
•