Closed Bug 1399489 Opened 2 years ago Closed 2 years ago

CanvasLayer::CanvasLayer(LayerManager*, void*): missing initialisations

Categories

(Core :: Graphics: Layers, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla57
Tracking Status
firefox-esr52 --- wontfix
firefox55 --- wontfix
firefox56 --- wontfix
firefox57 --- fixed

People

(Reporter: jseward, Assigned: jseward)

Details

(Whiteboard: [gfx-noted])

Attachments

(2 files)

CanvasLayer::CanvasLayer(LayerManager*, void*) lacks an initialisation for
CanvasLayer::mSamplingFilter.  This is seen fairly readily when running
Mochitests on Valgrind.

In particular, CanvasLayer::SetSamplingFilter() compares its argument
against the uninitialised mSamplingFilter.  One effect is that the call to
Mutated() may randomly be omitted, if the garbage mSamplingFilter value
happens to be the same as aSamplingFilter.
Attached file Memcheck complaint
Test path = dom/canvas/test/webgl-conf/generated
Attachment #8907619 - Flags: review?(nical.bugzilla)
Assignee: nobody → jseward
Attachment #8907619 - Flags: review?(nical.bugzilla) → review+
Pushed by jseward@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/dffc040eb2f8
CanvasLayer::CanvasLayer(LayerManager*, void*): missing initialisations.  r=nical.
https://hg.mozilla.org/mozilla-central/rev/dffc040eb2f8
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.