Closed
Bug 1399505
Opened 7 years ago
Closed 7 years ago
Make basic position:sticky work with layers-free webrender
Categories
(Core :: Graphics: WebRender, defect, P1)
Tracking
()
RESOLVED
FIXED
mozilla57
| Tracking | Status | |
|---|---|---|
| firefox57 | --- | unaffected |
| firefox58 | --- | fixed |
People
(Reporter: kats, Assigned: kats)
References
Details
(Whiteboard: [wr-mvp] [gfx-noted])
Attachments
(4 files)
Stepping stone towards full position:sticky support (which is tracked by bug 1366295). For the purposes of this bug I'm going to use the attached test page as a goal. The test page should work correctly in layers-free webrender (with and without APZ).
|
Assignee | |
Comment 1•7 years ago
|
||
This will need servo/webrender#1701
See Also: → https://github.com/servo/webrender/pull/1701
|
||
Updated•7 years ago
|
Status: NEW → ASSIGNED
Priority: P3 → P1
Whiteboard: [gfx-noted][wr-mvp][triage] → [wr-mvp] [gfx-noted]
Target Milestone: --- → mozilla57
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
|
Assignee | |
Comment 4•7 years ago
|
||
This test page makes the element sticky on both the top and the bottom. This also works with the attached patches.
|
|
Assignee | |
Comment 5•7 years ago
|
||
Try push is at https://treeherder.mozilla.org/#/jobs?repo=try&revision=95dcf059e2f479b1b6cc9a5988cf9bb28921d8fe - shows two sticky tests that previously failed are now passing.
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
||
Updated•7 years ago
|
status-firefox57:
--- → unaffected
|
|
Assignee | |
Comment 8•7 years ago
|
||
Updated try push is at https://treeherder.mozilla.org/#/jobs?repo=try&revision=0a461d8b8ecb71e1d6085bc915536cb1892e339f, green
|
||
Comment 9•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8907718 [details] Bug 1399505 - Expose the API to add sticky frames to the WR display list. https://reviewboard.mozilla.org/r/179390/#review187224
Attachment #8907718 -
Flags: review?(mstange) → review+
|
|
||
Comment 10•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8907719 [details] Bug 1399505 - Generate WR sticky frames from nsDisplayStickyPosition display items. https://reviewboard.mozilla.org/r/179392/#review187226
Attachment #8907719 -
Flags: review?(mstange) → review+
|
|
Assignee | |
Comment 11•7 years ago
|
||
Try push with patches rebased to master: https://treeherder.mozilla.org/#/jobs?repo=try&revision=48f609eb181fe37d73da3b10fb0057a856c9ee9d
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
||
Comment 14•7 years ago
|
||
Pushed by kgupta@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/40af6e459538 Expose the API to add sticky frames to the WR display list. r=mstange https://hg.mozilla.org/integration/autoland/rev/fd7e2ce2fc92 Generate WR sticky frames from nsDisplayStickyPosition display items. r=mstange
|
|
||
Comment 15•7 years ago
|
||
Backout by philringnalda@gmail.com: https://hg.mozilla.org/integration/autoland/rev/433c120883e9 Backed out 2 changesets for build bustage when it met a merge from m-c
|
||
Comment 16•7 years ago
|
||
Assuming I'm seeing the right thing, when it met https://hg.mozilla.org/integration/autoland/rev/5c407eb7c7ef, resulting in https://treeherder.mozilla.org/logviewer.html#?job_id=132346538&repo=autoland
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
|
||
Comment 19•7 years ago
|
||
Pushed by kgupta@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c81fde3ad750 Expose the API to add sticky frames to the WR display list. r=mstange https://hg.mozilla.org/integration/autoland/rev/74295a7f332d Generate WR sticky frames from nsDisplayStickyPosition display items. r=mstange
|
||
Comment 20•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/c81fde3ad750 https://hg.mozilla.org/mozilla-central/rev/74295a7f332d
You need to log in
before you can comment on or make changes to this bug.
Description
•