Closed Bug 1399505 Opened 2 years ago Closed 2 years ago

Make basic position:sticky work with layers-free webrender

Categories

(Core :: Graphics: WebRender, defect, P1)

Other Branch
defect

Tracking

()

RESOLVED FIXED
mozilla57
Tracking Status
firefox57 --- unaffected
firefox58 --- fixed

People

(Reporter: kats, Assigned: kats)

References

Details

(Whiteboard: [wr-mvp] [gfx-noted])

Attachments

(4 files)

Stepping stone towards full position:sticky support (which is tracked by bug 1366295).

For the purposes of this bug I'm going to use the attached test page as a goal. The test page should work correctly in layers-free webrender (with and without APZ).
Status: NEW → ASSIGNED
Priority: P3 → P1
Whiteboard: [gfx-noted][wr-mvp][triage] → [wr-mvp] [gfx-noted]
Target Milestone: --- → mozilla57
This test page makes the element sticky on both the top and the bottom. This also works with the attached patches.
Comment on attachment 8907718 [details]
Bug 1399505 - Expose the API to add sticky frames to the WR display list.

https://reviewboard.mozilla.org/r/179390/#review187224
Attachment #8907718 - Flags: review?(mstange) → review+
Comment on attachment 8907719 [details]
Bug 1399505 - Generate WR sticky frames from nsDisplayStickyPosition display items.

https://reviewboard.mozilla.org/r/179392/#review187226
Attachment #8907719 - Flags: review?(mstange) → review+
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/40af6e459538
Expose the API to add sticky frames to the WR display list. r=mstange
https://hg.mozilla.org/integration/autoland/rev/fd7e2ce2fc92
Generate WR sticky frames from nsDisplayStickyPosition display items. r=mstange
Backout by philringnalda@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/433c120883e9
Backed out 2 changesets for build bustage when it met a merge from m-c
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c81fde3ad750
Expose the API to add sticky frames to the WR display list. r=mstange
https://hg.mozilla.org/integration/autoland/rev/74295a7f332d
Generate WR sticky frames from nsDisplayStickyPosition display items. r=mstange
You need to log in before you can comment on or make changes to this bug.