1399511 - Wrong message displayed when clicking on an empty section in about:telemetry

Status: VERIFIED FIXED

(Toolkit :: Telemetry, enhancement, P2)

Description

[Francesco Lodolo [:flod]]

Noticed today when checking about:telemetry

If you click on an empty section, the text will say something like: 

> Sorry! There are no results in Browser Hangs for “”

It should probably say something like

> There are currently no items to display in Browser Hangs.

Comment 1

[Francesco Lodolo [:flod]]

Attachment: Bug 1399511 - Update message displayed when a section has no data in about:telemetry

Review commit: https://reviewboard.mozilla.org/r/180126/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/180126/

Comment 2

[Chris H-C :chutten]

Comment on attachment 8908476 [details]
Bug 1399511 - Update message displayed when a section has no data in about:telemetry

https://reviewboard.mozilla.org/r/180126/#review185488

Seems like it should work. How does it test out with sections like "Raw Payload" (present for pings like the BHR ping) that don't have search or results?

Comment 3

[Francesco Lodolo [:flod]]

(In reply to Chris H-C :chutten from comment #2)
> Seems like it should work. How does it test out with sections like "Raw
> Payload" (present for pings like the BHR ping) that don't have search or
> results?

When testing, for example on BHR ping, raw payload always has content for me (there is also no search field).

I only see that message when a section is empty (e.g. Main type, Browser hangs).

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8998495d56dc
Update message displayed when a section has no data in about:telemetry r=chutten

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/8998495d56dc

Comment 6

[Francesco Lodolo [:flod]]

Works as expected in 57.0a1 (2017-09-16) (64 bit)