Closed Bug 1399548 Opened 3 years ago Closed 3 years ago

Prevent unnecessary updates in toolbox react components

Categories

(DevTools :: Framework, defect)

defect
Not set
normal

Tracking

(firefox57 fixed)

RESOLVED FIXED
Firefox 57
Tracking Status
firefox57 --- fixed

People

(Reporter: ochameau, Assigned: ochameau)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

toolbox-controller.js frames represent a quite significant part of processing for the toolbox loading.
This is due to too many updates for the component and its hiearchy.
  https://perfht.ml/2eylj9K
Comment on attachment 8907690 [details]
Bug 1399548 - Prevent updating toolbox react component until it is ready to be displayed.

https://reviewboard.mozilla.org/r/179352/#review184500
Attachment #8907690 - Flags: review?(gtatum) → review+
Pushed by apoirot@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0e2f8ba6e45c
Prevent updating toolbox react component until it is ready to be displayed. r=gregtatum
https://hg.mozilla.org/mozilla-central/rev/0e2f8ba6e45c
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.