1399584 - Update context menu icons on back/forward buttons to match Photon style

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P1)

Description

[Gustavo Silva]

Attachment: Context menu back icon using the old style

When right-clicking the back/forward buttons in Firefox, the icons used in the context menu haven't been updated to match the new Photon visual style.

Comment 1

[Dão Gottwald [:dao]]

Attachment: Bug 1399584 - Update Back/Forward context menu icons.

Review commit: https://reviewboard.mozilla.org/r/181706/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/181706/

Comment 2

[Dale Harvey (:daleharvey)]

Comment on attachment 8910215 [details]
Bug 1399584 - Update Back/Forward context menu icons.

https://reviewboard.mozilla.org/r/181706/#review187496

I didnt realise could right click on the back / forward arrows, looks great, cheers

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/44d4581ca826
Update Back/Forward context menu icons. r=daleharvey

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/44d4581ca826

Comment 5

[Dão Gottwald [:dao]]

Comment on attachment 8910215 [details]
Bug 1399584 - Update Back/Forward context menu icons.

Approval Request Comment
[Feature/Bug causing the regression]: photon-visual polish
[User impact if declined]: Back/Forward context menu uses legacy icons
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: not yet
[Needs manual test from QE? If yes, steps to reproduce]:
[List of other uplifts needed for the feature/fix]: /
[Is the change risky?]: no
[Why is the change risky/not risky?]: simple isolated fix
[String changes made/needed]: /

Comment 6

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8910215 [details]
Bug 1399584 - Update Back/Forward context menu icons.

p1 bug to polish photon, taking it!
Should be in 57b3

Comment 7

[Dão Gottwald [:dao]]

https://hg.mozilla.org/releases/mozilla-beta/rev/4dd2a72249a856c875f09f31e06552cf7557886e

Comment 8

[Deac Alin]

Tested on Linux 16.04 x 64, Mac OSX 10.12.5 and Windows 10 x 64 Latest Nightly 58.0a1
Build ID 20170925100307. Now, the cContext menu icons are updated to match new Photon style. Verified - Fixed. Thank you

Comment 9

[Andrei Vaida [:avaida]]

Let's make sure this works as intended on Beta 57 as well.

Comment 10

[Alexandru Simonca [:asimonca], Release Desktop QA]

Verified fixed in Beta 57.0b9 on Windows 10 x64, macOS 10.13.1 and Ubuntu 16.04 x64.