Update context menu icons on back/forward buttons to match Photon style

VERIFIED FIXED in Firefox 57

Status

()

Firefox
Theme
P1
normal
VERIFIED FIXED
4 months ago
3 months ago

People

(Reporter: Gustavo Silva, Assigned: dao)

Tracking

(Blocks: 1 bug)

Trunk
Firefox 58
All
Unspecified
Points:
---

Firefox Tracking Flags

(firefox57 verified, firefox58 verified)

Details

(Whiteboard: [reserve-photon-visual])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

(Reporter)

Description

4 months ago
Created attachment 8907735 [details]
Context menu back icon using the old style

When right-clicking the back/forward buttons in Firefox, the icons used in the context menu haven't been updated to match the new Photon visual style.
(Assignee)

Updated

4 months ago
Blocks: 1325171
Status: UNCONFIRMED → NEW
status-firefox57: ? → ---
Ever confirmed: true
Priority: -- → P4
Whiteboard: [reserve-photon-visual]
(Assignee)

Updated

4 months ago
Flags: qe-verify+

Updated

4 months ago
QA Contact: ovidiu.boca
Comment hidden (mozreview-request)
(Assignee)

Updated

4 months ago
Assignee: nobody → dao+bmo
Status: NEW → ASSIGNED
Priority: P4 → P1

Updated

4 months ago
Iteration: --- → 57.3 - Sep 19
Comment on attachment 8910215 [details]
Bug 1399584 - Update Back/Forward context menu icons.

https://reviewboard.mozilla.org/r/181706/#review187496

I didnt realise could right click on the back / forward arrows, looks great, cheers
Attachment #8910215 - Flags: review?(dharvey) → review+

Comment 3

4 months ago
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/44d4581ca826
Update Back/Forward context menu icons. r=daleharvey

Updated

4 months ago
Iteration: 57.3 - Sep 19 → ---
https://hg.mozilla.org/mozilla-central/rev/44d4581ca826
Status: ASSIGNED → RESOLVED
Last Resolved: 4 months ago
status-firefox58: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
(Assignee)

Comment 5

4 months ago
Comment on attachment 8910215 [details]
Bug 1399584 - Update Back/Forward context menu icons.

Approval Request Comment
[Feature/Bug causing the regression]: photon-visual polish
[User impact if declined]: Back/Forward context menu uses legacy icons
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: not yet
[Needs manual test from QE? If yes, steps to reproduce]:
[List of other uplifts needed for the feature/fix]: /
[Is the change risky?]: no
[Why is the change risky/not risky?]: simple isolated fix
[String changes made/needed]: /
Attachment #8910215 - Flags: approval-mozilla-beta?
Comment on attachment 8910215 [details]
Bug 1399584 - Update Back/Forward context menu icons.

p1 bug to polish photon, taking it!
Should be in 57b3
Attachment #8910215 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Tested on Linux 16.04 x 64, Mac OSX 10.12.5 and Windows 10 x 64 Latest Nightly 58.0a1
Build ID 20170925100307. Now, the cContext menu icons are updated to match new Photon style. Verified - Fixed. Thank you
Status: RESOLVED → VERIFIED
status-firefox58: fixed → verified
Flags: qe-verify+
Let's make sure this works as intended on Beta 57 as well.
Flags: qe-verify+
Verified fixed in Beta 57.0b9 on Windows 10 x64, macOS 10.13.1 and Ubuntu 16.04 x64.
status-firefox57: fixed → verified
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.