1399648 - Get browser_aboutHome.js passing on both about:homes with activity stream or not

Status: RESOLVED FIXED

(Firefox :: New Tab Page, defect)

Description

[Ed Lee :Mardak]

+++ This bug was initially created as a clone of Bug #1396274 +++

Some stuff will probably need to be skipped and others fixed

Comment 1

[Ed Lee :Mardak]

I split out the imitation test which actually runs fine with activity stream, and it doesn't leak. But now it's leaking about:addons: https://treeherder.mozilla.org/#/jobs?repo=try&revision=25d9b7491a405eff873fabf0b7acb89aca5d9e2e&selectedJob=130866368

Potentially there's something leaky when enabling and disabling about:home activity stream? But only intermittently? 2 of 20 win32 debug non-e10s.

I also split out every single search test and search_suggestions is still timing out, so trying request longer for just that one test:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=25d9b7491a405eff873fabf0b7acb89aca5d9e2e&selectedJob=130865769

Trying again by skipping that intermittent leak, longer timeout, as well as skipping bug 1395602:
https://hg.mozilla.org/try/rev/644648fa9a9efc99a548cca1ce64a9c218d0fc1e

Comment 2

[Ed Lee :Mardak]

search_suggestion was still timing out (1 in 20) after various increases in requested longer timeouts on linux32/64 opt so just skipping
https://treeherder.mozilla.org/#/jobs?repo=try&revision=8eed62ff63c7d028eda52b89cb8d4867914738aa&selectedJob=130892363

search_composing was also timing out (1 in 80) on linux32 opt only so far.. so just skipping
https://treeherder.mozilla.org/#/jobs?repo=try&revision=60d70b73cfb10e14168c2566af3093b0d171869a&selectedJob=130898682

Latest set of test splitting and skipping:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=99402ed4f6b78e1810b466c487ef26cfa0630c49

Comment 3

[Ed Lee :Mardak]

Attachment: Bug 1399648 - Get browser_aboutHome.js passing on both about:homes with activity stream or not.

Review commit: https://reviewboard.mozilla.org/r/179702/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/179702/

Comment 4

[Ed Lee :Mardak]

Still waiting on mac but my try and mozreview try look good:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=99402ed4f6b78e1810b466c487ef26cfa0630c49
https://treeherder.mozilla.org/#/jobs?repo=try&revision=fb30c23c858a

Feel free to autoland if it's good. (And if export bug 1399607 is good too)

Comment 5

[Ed Lee :Mardak]

Looks like your try from yesterday with the combined aboutHome_search tests with request(2) are timing out 1 in 16:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=f6fdd141314a86c3d5e40aac8032c83629f6a11c&filter-searchStr=mac%20(bc

In particular they seem to timeout at "composing"

Not sure what that will mean for the split up tests in this patch. Maybe will need to skip _composing for osx too. Will check this in the morning: https://treeherder.mozilla.org/#/jobs?repo=try&revision=fb30c23c858a&filter-searchStr=mac%20(bc

Comment 6

[Ursula Sarracini (:ursula)]

Comment on attachment 8908016 [details]
Bug 1399648 - Get browser_aboutHome.js passing on both about:homes with activity stream or not.

https://reviewboard.mozilla.org/r/179702/#review185112

Patch looks good, let's just wait on the finished try run to see if the search test still timeouts on Mac before we land it. Thanks!

Comment 7

[Ed Lee :Mardak]

With 7 of 20 mac opt, 1 of 20 mac debug, 1 of 20 mac opt no stylo, 3 of 20 mac debug no stylo timing out for browser_aboutHome_search_suggestion.js. I guess we'll just skip the test for now. Could possibly requestLongerTimeout(4) as it did before, but there's contentSearch tests that are running.

Comment 8

[Ed Lee :Mardak]

Comment on attachment 8908016 [details]
Bug 1399648 - Get browser_aboutHome.js passing on both about:homes with activity stream or not.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/179702/diff/1-2/

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f36eefa1beee
Get browser_aboutHome.js passing on both about:homes with activity stream or not. r=ursula

Comment 10

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/f36eefa1beee