1399682 - RecyclerView does not animate when updating top site positions with less than 8 (?) items

Status: RESOLVED WONTFIX

(Firefox for Android Graveyard :: Activity Stream, defect)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

STR
1) Long press top site
2) Select "pin..."

Expected: RecyclerView animates and the top site moves
Actual: The item does not animate and just pops into place

This is fine on my Nightly, 9-13, but broken in my local dev builds so something must have broken on m-c since the cut.

Comment 1

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Sebastian, do you know what might have caused this?

Comment 2

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

This is weird: I can reproduce on e5f80a639bfe (my latest pull from today), 160cd861b358 (merge on the 11th), and fd1ab37308c5 (merge on the 8th) but I don't see this behavior on Nightly from Play (9-13), which I'd expect to be newer than all of these builds. Note that I see this behavior on several devices.

Sebastian, before you did into what caused this, can you reproduce this on your local builds? Maybe it's just me for some reason.

Comment 3

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Oh, I see. It only happens when I have a not full set of top sites.

This seems like a silly issue to spend time fixing given how little time users will spend with less than 8 top sites so I'm going to close this.