Closed
Bug 1399702
Opened 7 years ago
Closed 7 years ago
Fix the sidebar tabs photon style in the dark theme
Categories
(DevTools :: General, enhancement, P3)
DevTools
General
Tracking
(firefox57 fixed)
RESOLVED
FIXED
Firefox 57
Tracking | Status | |
---|---|---|
firefox57 | --- | fixed |
People
(Reporter: gl, Assigned: gl)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
1.82 KB,
patch
|
pbro
:
review+
|
Details | Diff | Splinter Review |
In the dark theme, the sidebar tabs should have the same font color as the toolbox tabs. Also, Hover/Active font color (Light/Dark theme) — font should be same as it normally is on hover/active. It appears we can just remove everything in the dark theme section here http://searchfox.org/mozilla-central/source/devtools/client/shared/components/tabs/tabs.css#107
Assignee | ||
Updated•7 years ago
|
Summary: Fix te → Fix the sidebar tabs photon style in the dark theme
Assignee | ||
Comment 1•7 years ago
|
||
We also fix the sidebar tab font size 12px to match the toolbox tabs and reduced the left/right padding to 10px as requested in her photon docs. "Could we make Inspector sidebar tabs 12px font, and same side padding as the main tabs? (10px-ish?) "
Attachment #8907922 -
Flags: review?(pbrosset)
Updated•7 years ago
|
Attachment #8907922 -
Flags: review?(pbrosset) → review+
Pushed by gabriel.luong@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/2c3a82c4ad0a Fix the sidebar tabs photon style in the dark theme. r=pbro
Comment 3•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/2c3a82c4ad0a
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Comment 4•7 years ago
|
||
Comment on attachment 8907922 [details] [diff] [review] 1399702.patch Review of attachment 8907922 [details] [diff] [review]: ----------------------------------------------------------------- ::: devtools/client/shared/components/tabs/tabs.css @@ +27,5 @@ > display: flex; > justify-content: center; > padding: 4px 8px; > border: 1px solid transparent; > + font-size: 12px; FYI, 12px looks different on Windows and Linux. Might be worth using relative font-sizes (em units) instead.
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•