1399702 - Fix the sidebar tabs photon style in the dark theme

Status: RESOLVED FIXED

(DevTools :: General, enhancement, P3)

Description

[Gabriel Luong [:gl] (ΦωΦ)]

In the dark theme, the sidebar tabs should have the same font color as the toolbox tabs. 

Also, Hover/Active font color (Light/Dark theme) — font should be same as it normally is on hover/active.

It appears we can just remove everything in the dark theme section here http://searchfox.org/mozilla-central/source/devtools/client/shared/components/tabs/tabs.css#107

Comment 1

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: 1399702.patch

We also fix the sidebar tab font size 12px to match the toolbox tabs and reduced the left/right padding to 10px as requested in her photon docs. "Could we make Inspector sidebar tabs 12px font, and same side padding as the main tabs? (10px-ish?)
"

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2c3a82c4ad0a
Fix the sidebar tabs photon style in the dark theme. r=pbro

Comment 3

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/2c3a82c4ad0a

Comment 4

[Tim Nguyen :ntim]

Comment on attachment 8907922 [details] [diff] [review]
1399702.patch

Review of attachment 8907922 [details] [diff] [review]:
-----------------------------------------------------------------

::: devtools/client/shared/components/tabs/tabs.css
@@ +27,5 @@
>    display: flex;
>    justify-content: center;
>    padding: 4px 8px;
>    border: 1px solid transparent;
> +  font-size: 12px;

FYI, 12px looks different on Windows and Linux.

Might be worth using relative font-sizes (em units) instead.