Closed
Bug 1399725
Opened 7 years ago
Closed 7 years ago
Adjust the link color to match the photon styles
Categories
(DevTools :: Inspector, enhancement, P3)
DevTools
Inspector
Tracking
(firefox57 fixed)
RESOLVED
FIXED
Firefox 57
Tracking | Status | |
---|---|---|
firefox57 | --- | fixed |
People
(Reporter: gl, Assigned: gl)
Details
Attachments
(1 file)
1.36 KB,
patch
|
pbro
:
review+
|
Details | Diff | Splinter Review |
For the links that appears as an url in the rule view (ie, background-image: url("..<link>.."), we should adjust the link color to use --theme-highlight-purple upon Victoria's suggestion.
Assignee | ||
Updated•7 years ago
|
Summary: Adjust the link color in the rule view → Adjust the link color in the rule view to use --theme-highlight-purple
Assignee | ||
Comment 1•7 years ago
|
||
Actually, we stated we were gonna change the source link in the light theme to be --theme-comment. In the dark theme, we intend to change the link that appears in the rule view to be --theme-highlight-purple.
Assignee | ||
Updated•7 years ago
|
Summary: Adjust the link color in the rule view to use --theme-highlight-purple → Adjust the link color to match the photon styles
Assignee | ||
Comment 2•7 years ago
|
||
Attachment #8907941 -
Flags: review?(pbrosset)
Updated•7 years ago
|
Attachment #8907941 -
Flags: review?(pbrosset) → review+
Pushed by gabriel.luong@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/67672b4fecc4 Adjust the link color to match the photon styles. r=pbro
Comment 4•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/67672b4fecc4
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•