Adjust the link color to match the photon styles

RESOLVED FIXED in Firefox 57

Status

P3
normal
RESOLVED FIXED
a year ago
8 months ago

People

(Reporter: gl, Assigned: gl)

Tracking

unspecified
Firefox 57

Firefox Tracking Flags

(firefox57 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

a year ago
For the links that appears as an url in the rule view (ie, background-image: url("..<link>.."), we should adjust the link color to use --theme-highlight-purple upon Victoria's suggestion.
(Assignee)

Updated

a year ago
Summary: Adjust the link color in the rule view → Adjust the link color in the rule view to use --theme-highlight-purple
(Assignee)

Comment 1

a year ago
Actually, we stated we were gonna change the source link in the light theme to be --theme-comment. In the dark theme, we intend to change the link that appears in the rule view to be --theme-highlight-purple.
(Assignee)

Updated

a year ago
Summary: Adjust the link color in the rule view to use --theme-highlight-purple → Adjust the link color to match the photon styles
(Assignee)

Comment 2

a year ago
Created attachment 8907941 [details] [diff] [review]
1399725.patch
Attachment #8907941 - Flags: review?(pbrosset)
Attachment #8907941 - Flags: review?(pbrosset) → review+

Comment 3

a year ago
Pushed by gabriel.luong@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/67672b4fecc4
Adjust the link color to match the photon styles. r=pbro
https://hg.mozilla.org/mozilla-central/rev/67672b4fecc4
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57

Updated

8 months ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.