Closed Bug 1399767 Opened 6 years ago Closed 6 years ago

Remove preference "layout.css.clip-path-shapes.enabled"

Categories

(Core :: Layout, enhancement, P3)

Product:
Core
Component:
Layout
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla57
Tracking Flags:
Tracking Status
firefox57 --- fixed

People

(Reporter: TYLin, Assigned: TYLin)

References

(Blocks 1 open bug)

Details

(Keywords: dev-doc-complete)

Attachments

(1 file)

Bug 1399767 - Remove preference "layout.css.clip-path-shapes.enabled".
59 bytes, text/x-review-board-request
heycam
: review+
Details 
<basic-shape> for clip-path had been shipped in Firefox 54 (bug 1247229). It's been a while, so let's remove the preference "layout.css.clip-path-shapes.enabled".
Priority: -- → P3
Assignee: nobody → tlin
Status: NEW → ASSIGNED
Comment on attachment 8908499 [details]
Bug 1399767 - Remove preference "layout.css.clip-path-shapes.enabled".

https://reviewboard.mozilla.org/r/180162/#review185800

::: layout/style/test/property_database.js:4585
(Diff revision 1)
>      type: CSS_TYPE_LONGHAND,
>      initial_values: [ "none" ],
> -    other_values: [ "url(#mypath)", "url('404.svg#mypath')" ],
> -    invalid_values: []
> +    other_values: [
> +      "url(#mypath)", "url('404.svg#mypath')", "url(#my-clip-path)"
> +    ].concat(basicShapeSVGBoxValues).concat(basicShapeOtherValues),
> +    invalid_values: [basicShapeInvalidValues],

Should this be

  invalid_values: basicShapeInvalidValues,

instead?
Attachment #8908499 - Flags: review?(cam) → review+
Comment on attachment 8908499 [details]
Bug 1399767 - Remove preference "layout.css.clip-path-shapes.enabled".

https://reviewboard.mozilla.org/r/180162/#review185800

> Should this be
> 
>   invalid_values: basicShapeInvalidValues,
> 
> instead?

Right, I'll remove `[]` around `basicShapeInvalidValues`. Thanks for catching this.
https://hg.mozilla.org/mozilla-central/rev/c452e8622329
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
I've documented this by just adding a note to the Fx57 rel notes. I didn't think it was worth mentioning in the main docs.

https://developer.mozilla.org/en-US/Firefox/Releases/57#CSS
Keywords: dev-doc-needed → dev-doc-complete
You need to log in before you can comment on or make changes to this bug.