Closed Bug 1399795 Opened 2 years ago Closed 2 years ago

Recompute nsDisplayTransform bounds in display item retained mode

Categories

(Core :: Layout, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED

People

(Reporter: ethlin, Assigned: ethlin)

Details

Attachments

(1 file)

For R8 failures, I think it's because we suppose the 3d transform will not change after constructor. To fix this, we should recompute the bounds of the transform item when updating bounds.
I tested on local site and the patch works. For try server, there are some crash problems now.
Comment on attachment 8908042 [details]
Bug 1399795 - Recompute nsDisplayTransform bounds for 3D when updating the item bounds.

https://reviewboard.mozilla.org/r/179736/#review185018

Looks good!

Definitely interested as to why you get a crash though, that'll be fun.
Attachment #8908042 - Flags: review?(matt.woodrow) → review+
Priority: -- → P3
Pushed by ethlin@mozilla.com:
https://hg.mozilla.org/projects/graphics/rev/084f83687e37
Recompute nsDisplayTransform bounds for 3D when updating the item bounds. r=mattwoodrow
Comparing the without[1] and with[2] the patch result, R8 is fixed. There are some crashes in crashtest, R4, R7. For QR platform, there is a new failure in R1.

[1] https://treeherder.mozilla.org/#/jobs?repo=try&revision=256440d9deacb5259b659163525ee10aebc04f59
[2] https://treeherder.mozilla.org/#/jobs?repo=try&revision=5df8443d0dcf62c57f7ac7bd1dd719be53833822
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.