Identify the ID of the elements involved in SVG reference loops in the Web Console error messages

RESOLVED FIXED in Firefox 58

Status

()

P3
normal
RESOLVED FIXED
11 months ago
11 months ago

People

(Reporter: jwatt, Assigned: jwatt)

Tracking

unspecified
mozilla57
Points:
---

Firefox Tracking Flags

(firefox57 wontfix, firefox58 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

11 months ago
Right now when we encounter an SVG reference loop we break the loop and send an error message to the Web Console noting that there is a loop. This isn't much help for developers though since in large Web apps they have little idea where to look to fix the issue. Since SVG elements that can be involved in loops are referenced by ID we could include the ID in the error message which would be a great help to developers.
(Assignee)

Comment 1

11 months ago
Created attachment 8908103 [details] [diff] [review]
patch
Attachment #8908103 - Flags: review?(longsonr)

Updated

11 months ago
Priority: -- → P3
Attachment #8908103 - Flags: review?(longsonr) → review+

Comment 2

11 months ago
Pushed by jwatt@jwatt.org:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c863089c7166
Identify the ID of the elements involved in SVG reference loops in the Web Console error messages. r=longsonr
https://hg.mozilla.org/mozilla-central/rev/c863089c7166
Status: NEW → RESOLVED
Last Resolved: 11 months ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Backed out for changing string without altering string ids (on request from flod):

https://hg.mozilla.org/mozilla-central/rev/0c49ebf4195ce51072b24aacf01eaaffdcff9be6
Status: RESOLVED → REOPENED
Flags: needinfo?(longsonr)
Resolution: FIXED → ---
(Assignee)

Comment 5

11 months ago
My fault. I should have requested an appropriate l10n reviewer as well.
Flags: needinfo?(longsonr)
(Assignee)

Updated

11 months ago
Flags: needinfo?(jwatt)
You don't necessarily need review from l10n, as long as you change string IDs when landing string changes
https://developer.mozilla.org/en-US/docs/Mozilla/Localization/Localization_content_best_practices#Changing_existing_strings
(Assignee)

Comment 7

11 months ago
Okay, I'll reland after I've read through that doc and got up to date with current l10n practice. Thanks for the link and for catching this.

Updated

11 months ago
status-firefox57: fixed → wontfix
status-firefox58: --- → affected

Comment 8

11 months ago
Pushed by jwatt@jwatt.org:
https://hg.mozilla.org/integration/mozilla-inbound/rev/71a0b9ae6f97
Identify the ID of the elements involved in SVG reference loops in the Web Console error messages. r=longsonr

Comment 9

11 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/71a0b9ae6f97
Status: REOPENED → RESOLVED
Last Resolved: 11 months ago11 months ago
status-firefox58: affected → fixed
Resolution: --- → FIXED
(Assignee)

Updated

11 months ago
Flags: needinfo?(jwatt)
You need to log in before you can comment on or make changes to this bug.