Closed Bug 1399853 Opened 2 years ago Closed 2 years ago

Identify the ID of the elements involved in SVG reference loops in the Web Console error messages

Categories

(Core :: SVG, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla57
Tracking Status
firefox57 --- wontfix
firefox58 --- fixed

People

(Reporter: jwatt, Assigned: jwatt)

Details

Attachments

(1 file)

Right now when we encounter an SVG reference loop we break the loop and send an error message to the Web Console noting that there is a loop. This isn't much help for developers though since in large Web apps they have little idea where to look to fix the issue. Since SVG elements that can be involved in loops are referenced by ID we could include the ID in the error message which would be a great help to developers.
Attached patch patchSplinter Review
Attachment #8908103 - Flags: review?(longsonr)
Priority: -- → P3
Attachment #8908103 - Flags: review?(longsonr) → review+
Pushed by jwatt@jwatt.org:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c863089c7166
Identify the ID of the elements involved in SVG reference loops in the Web Console error messages. r=longsonr
https://hg.mozilla.org/mozilla-central/rev/c863089c7166
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Backed out for changing string without altering string ids (on request from flod):

https://hg.mozilla.org/mozilla-central/rev/0c49ebf4195ce51072b24aacf01eaaffdcff9be6
Status: RESOLVED → REOPENED
Flags: needinfo?(longsonr)
Resolution: FIXED → ---
My fault. I should have requested an appropriate l10n reviewer as well.
Flags: needinfo?(longsonr)
Flags: needinfo?(jwatt)
Okay, I'll reland after I've read through that doc and got up to date with current l10n practice. Thanks for the link and for catching this.
Pushed by jwatt@jwatt.org:
https://hg.mozilla.org/integration/mozilla-inbound/rev/71a0b9ae6f97
Identify the ID of the elements involved in SVG reference loops in the Web Console error messages. r=longsonr
https://hg.mozilla.org/mozilla-central/rev/71a0b9ae6f97
Status: REOPENED → RESOLVED
Closed: 2 years ago2 years ago
Resolution: --- → FIXED
Flags: needinfo?(jwatt)
You need to log in before you can comment on or make changes to this bug.