Closed Bug 1399878 Opened 3 years ago Closed 3 years ago
_INCLUDES instead of CFLAGS in some media moz .build files
59 bytes, text/x-review-board-request
I'm not sure why these moz.build files are written this way, but a few moz.build files under media/ set include paths by doing things like `CFLAGS += [ '-I%s/media/libaom/config/win/x64/' % TOPSRCDIR ]`. These are easily translated to `LOCAL_INCLUDES`, which is more sensible and doesn't break my WSL build with absolute Posix paths being passed to cl.exe.
Comment on attachment 8908151 [details] bug 1399878 - Use LOCAL_INCLUDES instead of CFLAGS in some media moz.build files. https://reviewboard.mozilla.org/r/179834/#review185572 Weird. A potential follow-up would be to lint the value of CFLAGS and cousins and reject anti-patterns like this.
Attachment #8908151 - Flags: review?(gps) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/305e742634e5 Use LOCAL_INCLUDES instead of CFLAGS in some media moz.build files. r=gps
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/6cde1d8f17ad Fix case of LOCAL_INCLUDES; r=me
You need to log in before you can comment on or make changes to this bug.