Use LOCAL_INCLUDES instead of CFLAGS in some media moz.build files

RESOLVED FIXED in Firefox 57

Status

RESOLVED FIXED
a year ago
9 months ago

People

(Reporter: ted, Assigned: ted)

Tracking

(Blocks: 1 bug)

unspecified
mozilla57

Firefox Tracking Flags

(firefox57 fixed)

Details

Attachments

(1 attachment)

I'm not sure why these moz.build files are written this way, but a few moz.build files under media/ set include paths by doing things like `CFLAGS += [ '-I%s/media/libaom/config/win/x64/' % TOPSRCDIR ]`. These are easily translated to `LOCAL_INCLUDES`, which is more sensible and doesn't break my WSL build with absolute Posix paths being passed to cl.exe.
Comment hidden (mozreview-request)

Comment 3

a year ago
mozreview-review
Comment on attachment 8908151 [details]
bug 1399878 - Use LOCAL_INCLUDES instead of CFLAGS in some media moz.build files.

https://reviewboard.mozilla.org/r/179834/#review185572

Weird.

A potential follow-up would be to lint the value of CFLAGS and cousins and reject anti-patterns like this.
Attachment #8908151 - Flags: review?(gps) → review+

Comment 4

a year ago
Pushed by gszorc@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/305e742634e5
Use LOCAL_INCLUDES instead of CFLAGS in some media moz.build files. r=gps

Comment 5

a year ago
Pushed by gszorc@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6cde1d8f17ad
Fix case of LOCAL_INCLUDES; r=me
https://hg.mozilla.org/mozilla-central/rev/305e742634e5
https://hg.mozilla.org/mozilla-central/rev/6cde1d8f17ad
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57

Updated

9 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.