Open Bug 1399883 Opened 9 years ago Updated 1 year ago

Clicking empty area in about:preferences can change preferences

Categories

(Firefox :: Settings UI, defect, P3)

56 Branch
defect

Tracking

()

People

(Reporter: Oriol, Unassigned)

References

Details

Attachments

(1 file)

Attached image screencast.gif —
Go to about:preferences Click some empty area Result: Most probably you selected the radio or check button at the left. Expected: Radio and checked buttons should only be selected when clicking them or their description. Lots of times I have changed my preferences by mistake because I clicked an empty area and then it's so annoying because I have to guess which was the previously selected preference.
I _think_ this might be intentional. Tina, do you remember? I seem to recall some effort went in to increase the click area... am I mistaken?
Flags: needinfo?(thsieh)
If it's intentional then it's not consistent because it does not happen e.g. with "Enable Container Tabs". And please reconsider, it's so annoying when some pref is changed by mistake.
Priority: -- → P3
Hi Oriol and Mike, Here's the previous spec: https://docs.google.com/presentation/d/1EA-qGEjhkebW9IbUZ_fv_XYflu5dlutc60Nw57nT5sQ/edit#slide=id.g18289739c9_3_7 The recommended width of the active area is the width of the longest item in the group. Yes, it was one of our inconsistency works. If I recalled it correctly, we fixed that before 56. Not sure what made it changed but it'll be good if we can apply the rule for every checkbox and radio button :)
Flags: needinfo?(thsieh)
Thanks, that would definitely be an improvement (but I would still prefer the action area to be the limited by the text of the current item).
Severity: normal → S3
Duplicate of this bug: 1880616
Duplicate of this bug: 1613076
Duplicate of this bug: 1404560
Duplicate of this bug: 1518120
Duplicate of this bug: 1202492
Duplicate of this bug: 1426394
Duplicate of this bug: 1420651
Duplicate of this bug: 1870443
Duplicate of this bug: 802862
No longer duplicate of this bug: 802862
Duplicate of this bug: 1953564

Hi, I'm not sure 1953564 is an actual duplicate of this bug. This bug is about clicking in the preferences window while 1953564 was about selecting (click and drag) text in the preferences window. My understanding is those are two different types of interactions. Are they supposed to be handled the same way in the preferences window?

Yeah seem different. This one needs something like

checkbox, radio {
  max-width: max-content;
}

While bug 1953564 one needs to check if there is a selection in the JS event listener.

Ack, yes, you're right. Thanks for the catch.

No longer duplicate of this bug: 1953564
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: