Closed
Bug 1399928
Opened 7 years ago
Closed 7 years ago
RegExpShared source field should be a GCPtr
Categories
(Core :: JavaScript: GC, enhancement)
Tracking
()
RESOLVED
FIXED
mozilla57
| Tracking | Status | |
|---|---|---|
| firefox57 | --- | fixed |
People
(Reporter: jonco, Assigned: jonco)
Details
Attachments
(1 file)
|
931 bytes,
patch
|
sfink
:
review+
|
Details | Diff | Splinter Review |
At the moment it's a HeapPtr<JSAtom*>, a hangover from before RegExpShared was a GC thing. We use GCPtr for pointers beteween GC things and HeapPtr for pointers from the malloced heap to GC things. This case works as it is, but only because JSAtoms are not nursery allocated.
|
Assignee | |
Comment 1•7 years ago
|
||
Attachment #8908209 -
Flags: review?(sphink)
|
||
Updated•7 years ago
|
Attachment #8908209 -
Flags: review?(sphink) → review+
Pushed by jcoppeard@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/53d445528ef2 RegExpShared::source should be a GCPtr r=sfink
|
||
Comment 3•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/53d445528ef2
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in
before you can comment on or make changes to this bug.
Description
•