Closed
Bug 1399933
Opened 8 years ago
Closed 8 years ago
Remove assertion special case that allows for a fake object value
Categories
(Core :: JavaScript: GC, enhancement)
Tracking
()
RESOLVED
FIXED
mozilla57
| Tracking | Status | |
|---|---|---|
| firefox57 | --- | fixed |
People
(Reporter: jonco, Assigned: jonco)
Details
Attachments
(1 file)
|
7.31 KB,
patch
|
sfink
:
review+
|
Details | Diff | Splinter Review |
The assertion at the start of Value::setObject has a special case to allow you to pass 0x48, since that's used to create a special value in ObjectValueCrashOnTouch().
Let's remove this case and make clients use PoisonedObjectValue() instead.
|
Assignee | |
Comment 1•8 years ago
|
||
This patch also moves PoisonedObjectValue() to the 'js' namespace. It's not used outside the engine.
Attachment #8908211 -
Flags: review?(sphink)
|
||
Updated•8 years ago
|
Attachment #8908211 -
Flags: review?(sphink) → review+
Pushed by jcoppeard@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5c1007b062e3
Replace use of ObjectValueCrashOnTouch with PoisonedObjectValue r=sfink
|
||
Comment 3•8 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox57:
--- → fixed
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in
before you can comment on or make changes to this bug.
Description
•