1399979 - rename docker/config/docker_common.env

Status: RESOLVED FIXED

(Socorro :: General, task)

Description

[Will Kahn-Greene [:willkg] ET needinfo? me]

The docker environment has a bunch of configuration that's in a bunch of files designed to work in layers depending on the specifics of what's getting run and in what context (local dev environment vs. server environment vs. configuration specific to my computer).

That's all swell, but the file name docker/config/docker_common.env is confusing since it suggests it's for all docker-based environments and it's totally not.

This bug covers renaming that file and probably cleaning up some other things.

Comment 1

[Will Kahn-Greene [:willkg] ET needinfo? me]

There's a related file docker/config/local_development.env which holds things that should *never* be set in a server environment. This makes it easier for ops people to copy and paste and reduces the consequences of doing that poorly in a sea of like 150 configuration settings some with complex value syntax across a bunch of files and chaos and mayhem. This file name is terrible, too.

Maybe we should do something like this?:

* local_dev.env
* never_on_a_server.env

Does that make things clearer in intent?

Comment 2

[Miles Crabill [:miles]]

I think that local_dev.env makes sense to use. 'docker_common.env' definitely sounds like a base layer to be used across envs.

Comment 3

[Will Kahn-Greene [:willkg] ET needinfo? me]

I'll change this next week before it gets too ingrained and harder to change.

Comment 4

[Will Kahn-Greene [:willkg] ET needinfo? me]

Attachment: pr 4001 - move some vars between files

Comment 5

[[github robot]]

Commit pushed to master at https://github.com/mozilla-services/socorro

https://github.com/mozilla-services/socorro/commit/9197c137fb4b38bf8c174b24e75d77408462c336
bug 1399979 - move environment vars around (#4001)

This moves another couple of environment variables that should never get set
this way in a server environment into the local_development.env file where they
should be.

Comment 6

[Will Kahn-Greene [:willkg] ET needinfo? me]

Attachment: pr 4002 - rename config files for clarity

Comment 7

[[github robot]]

Commit pushed to master at https://github.com/mozilla-services/socorro

https://github.com/mozilla-services/socorro/commit/052d90bb2e94f581e61fae6c32c4aa523ad8d496
fixes bug 1399979 - rename base config files (#4002)

This renames the two base config files that we use for local development
environment to make it clearer what they do.