1400080 - Fix browser_webauthn_telemetry.js when u2f-hardware is in-tree

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect, P1)

Description

[J.C. Jones [:jcj] (he/him)]

(In reply to Tim Taubert [:ttaubert] from comment #12)
> (In reply to Pulsebot from comment #11)
> > Pushed by [e-mail]:
> > https://hg.mozilla.org/integration/mozilla-inbound/rev/c115eec567a6
> > Follow-up to disable parts of browser_webauthn_telemetry.js r=bustage
> 
> J.C., I had to disable the test partially, where it set
> webauthn.enable_usbtoken=true. How's that supposed to work with the real USB
> token code now?

Comment 1

[J.C. Jones [:jcj] (he/him)]

Attachment: Bug 1400080 - Remove impossible telemetry test from WebAuthn

Now that there are actual hardware devices, this test can't be run: it
depended on there being a deliberately-erroring implementation of WebAuthn
which would instantly reject promises. Fortunately, this test was really more
a test that telemetry scalars work properly than really the functionality
of WebAuthn.

Sadly, I don't see any way to re-enable this test without adding a new test-
only pref to the tree, which doesn't seem worth it for the telemetry.

So this patch removes the offending test completely which was backed out in
https://hg.mozilla.org/integration/mozilla-inbound/rev/c115eec567a6 .

Review commit: https://reviewboard.mozilla.org/r/180108/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/180108/

Comment 2

[Tim Taubert [:ttaubert] (inactive)]

Comment on attachment 8908462 [details]
Bug 1400080 - Remove impossible telemetry test from WebAuthn

https://reviewboard.mozilla.org/r/180108/#review185330

MozReview is so 2016. Other than that, LGTM :)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0aed7d43efe2
Remove impossible telemetry test from WebAuthn r=ttaubert

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/0aed7d43efe2