1400128 - Android build always links arm32's libc++ library even if MOZ_THUMB=1

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Comment 1

[Makoto Kato [:m_kato]]

http://searchfox.org/mozilla-central/rev/2c9a5993ac40ec1db8450e3e0a85702fa291b9e2/build/autoconf/android.m4#69 is invalid because cpu_arch_dir isn't absolute path

Comment 2

[Makoto Kato [:m_kato]]

Attachment: Bug 1400128 - Link thumb library of libc++ when using MOZ_THUMB=1 and NDK r11c.

cpu_arch_dir isn't absolute path, we cannot always detect thumb library for c++ library.  Our build tool still uses NDK r11c, so we should check thumb library correctly.

Review commit: https://reviewboard.mozilla.org/r/180130/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/180130/

Comment 3

[Nathan Froyd [:froydnj]]

Comment on attachment 8908475 [details]
Bug 1400128 - Link thumb library of libc++ when using MOZ_THUMB=1 and NDK r11c.

https://reviewboard.mozilla.org/r/180130/#review185546

Oh, whoops, nice catch!  Does that mean we've been linking the arm version since the chunk you deleted went in?

If that's the case, this patch is probably worth uplifting to 57.

Do we see a size win as a result of linking the thumb version?

Comment 4

[Makoto Kato [:m_kato]]

(In reply to Nathan Froyd [:froydnj] from comment #3)
> Comment on attachment 8908475 [details]
> Bug 1400128 - Link thumb library of libc++ when using MOZ_THUMB=1 and NDK
> r11c.
> 
> https://reviewboard.mozilla.org/r/180130/#review185546
> 
> Oh, whoops, nice catch!  Does that mean we've been linking the arm version
> since the chunk you deleted went in?

Just a little (10-15KB) for libxul.so

Comment 5

[Makoto Kato [:m_kato]]

> Oh, whoops, nice catch!  Does that mean we've been linking the arm version
> since the chunk you deleted went in?

Although I don't check more, this bug will be included when we use moz.configure support.

Comment 6

[Makoto Kato [:m_kato]]

And gnu stdc++ support seems to be broken after moving moz.configure, so I will file a bug for removing or fixing.

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/faa897d7948b

Comment 8

[Nathan Froyd [:froydnj]]

(In reply to Makoto Kato [:m_kato] from comment #6)
> And gnu stdc++ support seems to be broken after moving moz.configure, so I
> will file a bug for removing or fixing.

Removing would be better, since libstdc++ is probably going away when GCC is deleted from the NDK.  libstdc++ also won't work with the move to C++14 (requires switching to clang first), so we might as well eliminate it now.