Closed Bug 1400128 Opened 2 years ago Closed 2 years ago

Android build always links arm32's libc++ library even if MOZ_THUMB=1

Categories

(Firefox Build System :: General, enhancement)

Unspecified
Android
enhancement
Not set

Tracking

(firefox57 fixed)

RESOLVED FIXED
mozilla57
Tracking Status
firefox57 --- fixed

People

(Reporter: m_kato, Assigned: m_kato)

Details

Attachments

(1 file)

No description provided.
Summary: Android build always link arm32's libc++ library even if MOZ_THUMB=1 → Android build always links arm32's libc++ library even if MOZ_THUMB=1
Comment on attachment 8908475 [details]
Bug 1400128 - Link thumb library of libc++ when using MOZ_THUMB=1 and NDK r11c.

https://reviewboard.mozilla.org/r/180130/#review185546

Oh, whoops, nice catch!  Does that mean we've been linking the arm version since the chunk you deleted went in?

If that's the case, this patch is probably worth uplifting to 57.

Do we see a size win as a result of linking the thumb version?
Attachment #8908475 - Flags: review?(nfroyd) → review+
(In reply to Nathan Froyd [:froydnj] from comment #3)
> Comment on attachment 8908475 [details]
> Bug 1400128 - Link thumb library of libc++ when using MOZ_THUMB=1 and NDK
> r11c.
> 
> https://reviewboard.mozilla.org/r/180130/#review185546
> 
> Oh, whoops, nice catch!  Does that mean we've been linking the arm version
> since the chunk you deleted went in?

Just a little (10-15KB) for libxul.so
> Oh, whoops, nice catch!  Does that mean we've been linking the arm version
> since the chunk you deleted went in?

Although I don't check more, this bug will be included when we use moz.configure support.
And gnu stdc++ support seems to be broken after moving moz.configure, so I will file a bug for removing or fixing.
https://hg.mozilla.org/mozilla-central/rev/faa897d7948b
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
(In reply to Makoto Kato [:m_kato] from comment #6)
> And gnu stdc++ support seems to be broken after moving moz.configure, so I
> will file a bug for removing or fixing.

Removing would be better, since libstdc++ is probably going away when GCC is deleted from the NDK.  libstdc++ also won't work with the move to C++14 (requires switching to clang first), so we might as well eliminate it now.
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.