|Submitter||Diff||Changes||Open Issues||Last Updated|
|Error loading review requests:|
This happened twice already: code for Webextensions is ported from browser, and with that we port access keys. https://hg.mozilla.org/mozilla-central/diff/314cd9bfe986/mobile/android/locales/en-US/chrome/browser.properties#l1.17 Access keys in Android don't make any sense and they should not be ported. We should make a note in review to check for this mistake. Can we get a fix in quickly?
I'm not sure if I'm misreading the code, but is the button even used? https://hg.mozilla.org/mozilla-central/rev/314cd9bfe986
Sorry, this was my fault. I wrote this patch quite a while before the "remove accessKeys on android" bug and fix went in, and I overlooked it when landing. (In reply to Francesco Lodolo [:flod] from comment #1) > I'm not sure if I'm misreading the code, but is the button even used? Yes, but the process to get it to show up manually is pretty tedious. You need to install a webextension, then make an update available for that extension that requires one or moer new (promptable) permissions, then wait for the browser to check for updates (or use the debugger or preferences to trigger a quicker check). Then the extension's entry in about:addons gets an "Update" button and when that is pressed, the permissions dialog shows up with "Update" as one of the options. In any case, I'll put up the patch to remove the access key right now, sorry again for the hassle.
Comment on attachment 8908693 [details] Bug 1400129 Remove unused accessKey l10n property https://reviewboard.mozilla.org/r/180342/#review185500 Thanks for taking the time to explain the code ;-)
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/18dad63ef0c6 Remove unused accessKey l10n property r=flod