Closed Bug 1400148 Opened 4 years ago Closed 4 years ago
Don't use -1 to represent an unset ns
Because UBSan complains about casting -1: > runtime error: load of value 4294967295, which is not a valid value for type 'nsCursor'
Comment on attachment 8908483 [details] [diff] [review] Don't use -1 to represent an unset nsCursor Nice, thanks. >+ // This one is used for array sizing, and so better be the last >+ // one in this list... >+ eCursorCount, >+ >+ // ...except for this one. >+ eCursorInvalid = 255 eCursorCount + 1 perhaps. I couldn't see how long the list was from the patch, but whatever is fine.
Attachment #8908483 - Flags: review?(karlt) → review+
or -1, even...
https://hg.mozilla.org/integration/mozilla-inbound/rev/ff9e183ca0fe4d0f4afde67a56777769357477b8 Bug 1400148 - Don't use -1 to represent an unset nsCursor. r=karlt.
You need to log in before you can comment on or make changes to this bug.