1400148 - Don't use -1 to represent an unset nsCursor

Status: RESOLVED FIXED

(Core :: Widget, defect)

Description

[Nicholas Nethercote [inactive]]

Because UBSan complains about casting -1:

> runtime error: load of value 4294967295, which is not a valid value for type 'nsCursor'

Comment 1

[Nicholas Nethercote [inactive]]

Attachment: Don't use -1 to represent an unset nsCursor

Comment 2

[Karl Tomlinson (:karlt)]

Comment on attachment 8908483 [details] [diff] [review]
Don't use -1 to represent an unset nsCursor

Nice, thanks.

>+                // This one is used for array sizing, and so better be the last
>+                // one in this list...
>+                eCursorCount,
>+
>+                // ...except for this one.
>+                eCursorInvalid = 255

eCursorCount + 1 perhaps.  I couldn't see how long the list was from the patch, but whatever is fine.

Comment 3

[Karl Tomlinson (:karlt)]

or -1, even...

Comment 4

[Nicholas Nethercote [inactive]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ff9e183ca0fe4d0f4afde67a56777769357477b8
Bug 1400148 - Don't use -1 to represent an unset nsCursor. r=karlt.

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/ff9e183ca0fe