1400219 - Align permission status menulists in the permission dialog with the header and adjust the menulist margin

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect)

Description

[:prathiksha]

Attachment: Screen Shot 2017-09-15 at 5.34.20 PM.png

What it looks like right now:

Comment 1

[:prathiksha]

Attachment: What it should look like. ^

Comment 2

[Johann Hofmann [:johannh]]

Yeah, it seems like something made those menulists slightly larger? Would be nice to get this polish into 57.

Comment 3

[:prathiksha]

(In reply to Johann Hofmann [:johannh] from comment #2)
> Yeah, it seems like something made those menulists slightly larger? Would be
> nice to get this polish into 57.

Yess :)

Comment 4

[:prathiksha]

Attachment: Bug 1400219 - Align permission status menulists in the permission dialog with the header and adjust the menulist margin.

Review commit: https://reviewboard.mozilla.org/r/180262/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/180262/

Comment 5

[:prathiksha]

Comment on attachment 8908600 [details]
Bug 1400219 - Align permission status menulists in the permission dialog with the header and adjust the menulist margin.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/180262/diff/1-2/

Comment 6

[Johann Hofmann [:johannh]]

Hey Prathiksha, sorry, did you mean for me to review this (you forgot the "h" at the end of my IRC nick)?

I can do that if you like but the problem has been fixed on my machine, at least, so we might consider closing this as WORKSFORME. Let me know what you think :)

Comment 7

[:prathiksha]

(In reply to Johann Hofmann [:johannh] from comment #6)
> Hey Prathiksha, sorry, did you mean for me to review this (you forgot the
> "h" at the end of my IRC nick)?

yes, I'll just update the review comment, sorry about that.

> I can do that if you like but the problem has been fixed on my machine, at
> least, so we might consider closing this as WORKSFORME. Let me know what you
> think :)

I still think my patch will make the permission rows look neater. We should go ahead and land this bug. :)

Comment 8

[:prathiksha]

Comment on attachment 8908600 [details]
Bug 1400219 - Align permission status menulists in the permission dialog with the header and adjust the menulist margin.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/180262/diff/2-3/

Comment 9

[Johann Hofmann [:johannh]]

Comment on attachment 8908600 [details]
Bug 1400219 - Align permission status menulists in the permission dialog with the header and adjust the menulist margin.

https://reviewboard.mozilla.org/r/180262/#review187930

Works for me, thanks!

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e5c4c1634e3a
Align permission status menulists in the permission dialog with the header and adjust the menulist margin. r=johannh

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/e5c4c1634e3a

Comment 12

[:prathiksha]

Comment on attachment 8908600 [details]
Bug 1400219 - Align permission status menulists in the permission dialog with the header and adjust the menulist margin.

Approval Request Comment
[Feature/Bug causing the regression]: Bug 1385221
[User impact if declined]: no big impact, its just polish
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: no
[Needs manual test from QE? If yes, steps to reproduce]: no 
[List of other uplifts needed for the feature/fix]: no
[Is the change risky?]: no
[Why is the change risky/not risky?]: simple style changes
[String changes made/needed]: no

Comment 13

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8908600 [details]
Bug 1400219 - Align permission status menulists in the permission dialog with the header and adjust the menulist margin.

recent regression, low risk, beta57+

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/5fba16e588e6