Closed Bug 1400243 Opened 4 years ago Closed 4 years ago

CustomTab: no doorhanger displayed when log in to a page

Categories

(Firefox for Android Graveyard :: General, defect, P1)

57 Branch
ARM
Android
defect

Tracking

(fennec+, firefox55 unaffected, firefox56 unaffected, firefox57 verified)

VERIFIED FIXED
Firefox 57
Tracking Status
fennec + ---
firefox55 --- unaffected
firefox56 --- unaffected
firefox57 --- verified

People

(Reporter: sflorean, Assigned: jchen)

References

Details

Attachments

(2 files)

Environment: 
Device: Huawei Honor (Android 5.1.1);
Build: Nightly 57.0a1 (2017-09-15);

Steps to reproduce:
1. Enable Custom Tab;
2. Go to Twitter and log in.

Expected result:
A doorhanger is displayed asking to save the password.

Actual result:
No doorhanger is displayed. 

Notes: reproducible also on Facebook, Gmail.
Summary: CostomTab: no doorhanger displayed when log in to a page → CustomTab: no doorhanger displayed when log in to a page
Jim will this be fixed by bug 1393128?
Flags: needinfo?(nchen)
Priority: -- → P1
Assignee: nobody → esawin
Doesn't look like it, but I'll take it.
Assignee: esawin → nchen
Status: NEW → ASSIGNED
Flags: needinfo?(nchen)
Comment on attachment 8909610 [details]
Bug 1400243 - 1. Use universal DoorHanger in LoginManagerPrompter;

https://reviewboard.mozilla.org/r/181088/#review186486
Attachment #8909610 - Flags: review?(esawin) → review+
Comment on attachment 8909611 [details]
Bug 1400243 - 2. Small fixes to ActionBarHandler and FormAssistant;

https://reviewboard.mozilla.org/r/181090/#review186488
Attachment #8909611 - Flags: review?(esawin) → review+
Comment on attachment 8909611 [details]
Bug 1400243 - 2. Small fixes to ActionBarHandler and FormAssistant;

https://reviewboard.mozilla.org/r/181090/#review186490
Pushed by nchen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ef0402ba21c2
1. Use universal DoorHanger in LoginManagerPrompter; r=esawin
https://hg.mozilla.org/integration/autoland/rev/f07a6fbba625
2. Small fixes to ActionBarHandler and FormAssistant; r=esawin
https://hg.mozilla.org/mozilla-central/rev/ef0402ba21c2
https://hg.mozilla.org/mozilla-central/rev/f07a6fbba625
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Verified as fixed in build 57.0b5 with Samsung Galaxy Tab 3 (Android 7.0).
Status: RESOLVED → VERIFIED
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.