1400243 - CustomTab: no doorhanger displayed when log in to a page

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P1)

Description

[Sorina Florean [:sflorean]]

Environment: 
Device: Huawei Honor (Android 5.1.1);
Build: Nightly 57.0a1 (2017-09-15);

Steps to reproduce:
1. Enable Custom Tab;
2. Go to Twitter and log in.

Expected result:
A doorhanger is displayed asking to save the password.

Actual result:
No doorhanger is displayed. 

Notes: reproducible also on Facebook, Gmail.

Comment 1

[James Willcox (:snorp) ([e-mail]) (he/him)]

Jim will this be fixed by bug 1393128?

Comment 2

[(inactive) Jim Chen [:jchen] [:darchons]]

Doesn't look like it, but I'll take it.

Comment 3

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Bug 1400243 - 1. Use universal DoorHanger in LoginManagerPrompter;

Use the universal DoorHanger API from Prompt.jsm to show the login
doorhanger from any window. Also, refactor parts of LoginManagerPrompter
to use Services.jsm if possible.

Review commit: https://reviewboard.mozilla.org/r/181088/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/181088/

Comment 4

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Bug 1400243 - 2. Small fixes to ActionBarHandler and FormAssistant;

Small fixes to ride-along in this bug:
* Use localized ellipsis in ActionBarHandler if available.
* Fix one situation where the FormAssistPopup fails to hide.
* Handle an error case in FormAssistant.

Review commit: https://reviewboard.mozilla.org/r/181090/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/181090/

Comment 5

[Eugen Sawin [:esawin]]

Comment on attachment 8909610 [details]
Bug 1400243 - 1. Use universal DoorHanger in LoginManagerPrompter;

https://reviewboard.mozilla.org/r/181088/#review186486

Comment 6

[Eugen Sawin [:esawin]]

Comment on attachment 8909611 [details]
Bug 1400243 - 2. Small fixes to ActionBarHandler and FormAssistant;

https://reviewboard.mozilla.org/r/181090/#review186488

Comment 7

[Eugen Sawin [:esawin]]

Comment on attachment 8909611 [details]
Bug 1400243 - 2. Small fixes to ActionBarHandler and FormAssistant;

https://reviewboard.mozilla.org/r/181090/#review186490

Comment 8

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 8909610 [details]
Bug 1400243 - 1. Use universal DoorHanger in LoginManagerPrompter;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/181088/diff/1-2/

Comment 9

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 8909611 [details]
Bug 1400243 - 2. Small fixes to ActionBarHandler and FormAssistant;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/181090/diff/1-2/

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ef0402ba21c2
1. Use universal DoorHanger in LoginManagerPrompter; r=esawin
https://hg.mozilla.org/integration/autoland/rev/f07a6fbba625
2. Small fixes to ActionBarHandler and FormAssistant; r=esawin

Comment 11

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/ef0402ba21c2
https://hg.mozilla.org/mozilla-central/rev/f07a6fbba625

Comment 12

[Sorina Florean [:sflorean]]

Verified as fixed in build 57.0b5 with Samsung Galaxy Tab 3 (Android 7.0).