1400261 - Ensure spot bids are only made for configured zones

Status: RESOLVED FIXED

(Taskcluster :: Services, enhancement)

Description

[Dustin J. Mitchell [:dustin] (he/him)]

When determining bids, we should never make a bid for an AZ that is not configured, unless there is no AZ configuration at all.  That will avoid making bids for unconfigured AZs, which would then either fail or generate incorrectly-configured instances.

Comment 1

[Dustin J. Mitchell [:dustin] (he/him)]

I made some workers with the below definition, and they were created correctly.  All in one AZ (c), but that's down to pricing.

{
  "minCapacity": 10,
  "maxCapacity": 20,
  "scalingRatio": 0,
  "minPrice": 0,
  "maxPrice": 0.2,
  "canUseOndemand": false,
  "canUseSpot": true,
  "instanceTypes": [
    {
      "instanceType": "r3.xlarge",
      "capacity": 1,
      "utility": 1,
      "secrets": {},
      "scopes": [],
      "userData": {},
      "launchSpec": {}
    }
  ],
  "regions": [
    {
      "region": "us-east-1",
      "secrets": {},
      "scopes": [],
      "userData": {},
      "launchSpec": {
        "ImageId": "ami-79fe4f6f",
        "SecurityGroupIds": [
          "sg-12cd3762"
        ]
      }
    }
  ],
  "userData": {
    "dindImage": "taskcluster/dind-service:3.0"
  },
  "launchSpec": {},
  "secrets": {},
  "scopes": [
    "assume:worker-type:aws-provisioner-v1/dustin-bug1400261",
    "assume:worker-id:*"
  ],
  "description": "** WRITE THIS**",
  "owner": "** WRITE THIS **",
  "availabilityZones": [
    {
      "availabilityZone": "us-east-1a",
      "region": "us-east-1",
      "launchSpec": {
        "SubnetId": "subnet-566e060c"
      },
      "secrets": {},
      "userData": {}
    },
    {
      "availabilityZone": "us-east-1b",
      "region": "us-east-1",
      "launchSpec": {
        "SubnetId": "subnet-f2c93496"
      },
      "secrets": {},
      "userData": {}
    },
    {
      "availabilityZone": "us-east-1c",
      "region": "us-east-1",
      "launchSpec": {
        "SubnetId": "subnet-c52454e9"
      },
      "secrets": {},
      "userData": {}
    },
    {
      "availabilityZone": "us-east-1d",
      "region": "us-east-1",
      "launchSpec": {
        "SubnetId": "subnet-e7e6ccaf"
      },
      "secrets": {},
      "userData": {}
    },
    {
      "availabilityZone": "us-east-1e",
      "region": "us-east-1",
      "launchSpec": {
        "SubnetId": "subnet-deb5a8e2"
      },
      "secrets": {},
      "userData": {}
    },
    {
      "availabilityZone": "us-east-1f",
      "region": "us-east-1",
      "launchSpec": {
        "SubnetId": "subnet-7f720d73"
      },
      "secrets": {},
      "userData": {}
    }
  ]
}

Comment 2

[Dustin J. Mitchell [:dustin] (he/him)]

https://github.com/taskcluster/aws-provisioner/pull/162