Closed
Bug 1400266
Opened 7 years ago
Closed 6 years ago
Style the bookmarks and history sidebar tree arrows on Linux
Categories
(Firefox :: Theme, defect, P5)
Tracking
()
VERIFIED
FIXED
Firefox 63
Tracking | Status | |
---|---|---|
firefox63 | --- | verified |
People
(Reporter: Ovidiu, Assigned: Paenglab)
References
(Blocks 2 open bugs)
Details
Attachments
(2 files, 1 obsolete file)
243.53 KB,
image/png
|
Details | |
12.07 KB,
patch
|
dao
:
review+
|
Details | Diff | Splinter Review |
The sidebar tree doesn't respect the specifications, for example, the arrows from the "Bookmarks Toolbar", "Bookmarks Menu" are not the same as the ones from the spec. Please see the attachment.
Reporter | ||
Updated•7 years ago
|
Blocks: photon-visual
Whiteboard: [photon-visual][triage]
Comment 1•7 years ago
|
||
We currently can't style the arrows as specified because of bug 1381453.
Depends on: 1381453
Priority: -- → P5
Summary: The bookmarks and history sidebar doesn't match the specs. on Ubuntu → Style the bookmarks and history sidebar tree arrows on Linux
Whiteboard: [photon-visual][triage] → [reserve-photon-visual]
Updated•7 years ago
|
Flags: qe-verify?
Updated•7 years ago
|
Flags: qe-verify? → qe-verify+
Updated•7 years ago
|
QA Contact: ovidiu.boca
Updated•7 years ago
|
Flags: qe-verify+
QA Contact: ovidiu.boca
Whiteboard: [reserve-photon-visual]
Assignee | ||
Comment 2•6 years ago
|
||
I copied the Windows twisty icons for this patch.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Comment 3•6 years ago
|
||
From a quick look, it seems like this could fix bug 1298020 as well (rtl issues), hence adding a dependency.
Blocks: 1298020
Assignee | ||
Comment 4•6 years ago
|
||
Comment on attachment 8987596 [details] [diff] [review] Bug1400266- Linux-twisty.patch Hmm, somehow the r? wasn't applied.
Attachment #8987596 -
Flags: review?(dao+bmo)
Comment 5•6 years ago
|
||
Comment on attachment 8987596 [details] [diff] [review] Bug1400266- Linux-twisty.patch > * skin/classic/global/in-content/common.css (in-content/common.css) > * skin/classic/global/in-content/info-pages.css (in-content/info-pages.css) >- skin/classic/global/tree/twisty-clsd.png (tree/twisty-clsd.png) >- skin/classic/global/tree/twisty-open.png (tree/twisty-open.png) >+ skin/classic/global/tree/twisty-collapsed.svg (tree/twisty-collapsed.svg) >+ skin/classic/global/tree/twisty-collapsed-rtl.svg (tree/twisty-collapsed-rtl.svg) >+ skin/classic/global/tree/twisty-expanded.svg (tree/twisty-expanded.svg) nit: indentation is off >+++ b/toolkit/themes/linux/global/tree/twisty-collapsed-rtl.svg >@@ -0,0 +1,6 @@ >+<!-- This Source Code Form is subject to the terms of the Mozilla Public >+ - License, v. 2.0. If a copy of the MPL was not distributed with this >+ - file, You can obtain one at http://mozilla.org/MPL/2.0/. --> >+<svg width="9" height="9" xmlns="http://www.w3.org/2000/svg" stroke="context-fill" stroke-opacity="context-fill-opacity" stroke-width="1.6" fill="none"> Where does fill-opacity ever get set to a value different than 1? >+ <path d="m 6.5,0.5 -4,4 4,4"/> nit: use two spaces indentation
Attachment #8987596 -
Flags: review?(dao+bmo)
Assignee | ||
Comment 6•6 years ago
|
||
(In reply to Dão Gottwald [::dao] from comment #5) > Comment on attachment 8987596 [details] [diff] [review] > Bug1400266- Linux-twisty.patch > > Where does fill-opacity ever get set to a value different than 1? Nowhere yet. It's only ready if it's maybe used in the sidebar theming bug. Should I remove it completely? Then I'll do the same on Windows.
Comment 7•6 years ago
|
||
(In reply to Richard Marti (:Paenglab) from comment #6) > Should I remove it completely? Then I'll do the same on Windows. Yes, please.
Assignee | ||
Comment 8•6 years ago
|
||
(In reply to Dão Gottwald [::dao] from comment #5) > Comment on attachment 8987596 [details] [diff] [review] > Bug1400266- Linux-twisty.patch > > nit: indentation is off Fixed. > Where does fill-opacity ever get set to a value different than 1? Removed, also on Windows. > >+ <path d="m 6.5,0.5 -4,4 4,4"/> > > nit: use two spaces indentation Fixed, also on Windows.
Attachment #8987596 -
Attachment is obsolete: true
Attachment #8988768 -
Flags: review?(dao+bmo)
Comment 9•6 years ago
|
||
Comment on attachment 8988768 [details] [diff] [review] Bug1400266- Linux-twisty.patch Thanks!
Attachment #8988768 -
Flags: review?(dao+bmo) → review+
Assignee | ||
Updated•6 years ago
|
Keywords: checkin-needed
Comment 10•6 years ago
|
||
Pushed by dgottwald@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/93972d67be61 Use SVG icons for the twisties on Linux. r=dao
Keywords: checkin-needed
Updated•6 years ago
|
Updated•6 years ago
|
Blocks: png-cleanup
Comment 11•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/93972d67be61
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
Reporter | ||
Comment 12•6 years ago
|
||
I verified this issue on Ubuntu 16.04 with FF Nightly 63.0a1(2018-07-01) and I can confirm the fix. I will mark this as verified fixed.
Status: RESOLVED → VERIFIED
Updated•6 years ago
|
status-firefox57:
affected → ---
You need to log in
before you can comment on or make changes to this bug.
Description
•