Closed Bug 1400319 Opened 2 years ago Closed 2 years ago

Implement the photon styles for the rule view search highlights

Categories

(DevTools :: Inspector: Rules, enhancement, P3)

enhancement

Tracking

(firefox57 verified)

VERIFIED FIXED
Firefox 57
Tracking Status
firefox57 --- verified

People

(Reporter: gl, Assigned: gl)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Use #521C76 for the search result highlight color in the dark theme, and make the search highlight only highlighting the text.
For the yellow search highlight color, use #FFF89E
Attached patch 1400319.patchSplinter Review
This also replaces #ffee99 with --theme-highlight-yellow since this is the new yellow.
Attachment #8908760 - Flags: review?(jdescottes)
Comment on attachment 8908760 [details] [diff] [review]
1400319.patch

Review of attachment 8908760 [details] [diff] [review]:
-----------------------------------------------------------------

It's all good!
Attachment #8908760 - Flags: review?(jdescottes) → review+
Pushed by gabriel.luong@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0d93c364b753
Implement the photon styles for the rule view search highlights. r=jdescottes
https://hg.mozilla.org/mozilla-central/rev/0d93c364b753
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Build ID: 20170921100141
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:57.0) Gecko/20100101 Firefox/57.0

Verified as fixed on Firefox Nightly 57.0a1 on Windows 10 x 64, Mac OS X 10.12 and Ubuntu 16.04 x64.
Status: RESOLVED → VERIFIED
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.