Closed Bug 1400345 Opened 2 years ago Closed 2 years ago

Port bug 1397325 to TB [Fix broken font size for in-content pages]

Categories

(Thunderbird :: Theme, enhancement)

enhancement
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 57.0

People

(Reporter: Paenglab, Assigned: Paenglab)

Details

Attachments

(1 file)

Bug 1397325 changed some font sizes to make them according to Photon theme. We can follow this.
Simple port of https://hg.mozilla.org/mozilla-central/rev/ebd6591b323f
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8908737 - Flags: review?(jorgk)
Comment on attachment 8908737 [details] [diff] [review]
prefsFontFix.patch

I can see that the headings "Daily Start Page", etc. are a little larger now. I can't really say that I like that, what was wrong with the previous size?

Other than that, I can't see any difference, or perhaps the other text is a little larger, too, like 1.36 instead of 1.3 and 1.25 instead of 1.2, I can' tell which number corresponds to which text.

We don't need this:
+.tip-caption,
+.help-button {
+  font-size: 1rem;
+}
+
from the M-C patch, I assume.

However, I did notice something ugly which you might want to fix in another bug. The text which has no heading, like "Determine how Daily handles return receipts" or "Set your default junk mail settings. ..." is indented a little. That looks funny. Since it has no heading it should line up with the other headings, no?
(In reply to Jorg K (GMT+2) from comment #2)
> Comment on attachment 8908737 [details] [diff] [review]
> prefsFontFix.patch
> 
> I can see that the headings "Daily Start Page", etc. are a little larger
> now. I can't really say that I like that, what was wrong with the previous
> size?

I followed only Firefox. The font sizes should now be like the Photon specs.

> Other than that, I can't see any difference, or perhaps the other text is a
> little larger, too, like 1.36 instead of 1.3 and 1.25 instead of 1.2, I can'
> tell which number corresponds to which text.
> 
> We don't need this:
> +.tip-caption,
> +.help-button {
> +  font-size: 1rem;
> +}
> +
> from the M-C patch, I assume.

Yes, not used in TB.

> However, I did notice something ugly which you might want to fix in another
> bug. The text which has no heading, like "Determine how Daily handles return
> receipts" or "Set your default junk mail settings. ..." is indented a
> little. That looks funny. Since it has no heading it should line up with the
> other headings, no?

Yes this needs to be addressed in a new bug. Thanks for finding it.
Comment on attachment 8908737 [details] [diff] [review]
prefsFontFix.patch

(In reply to Richard Marti (:Paenglab) from comment #3)
> (In reply to Jorg K (GMT+2) from comment #2)
> > I can't really say that I like that, what was wrong with the previous
> > size?
> I followed only Firefox. The font sizes should now be like the Photon specs.
And we need to follow that 100%? E-Mail is a text processing program, so people are used to smaller font sizes.
Attachment #8908737 - Flags: review?(jorgk) → review+
We don't need but the changes aren't that big.
Keywords: checkin-needed
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/6d003073d4e6
Port bug 1397325 to TB [Fix broken font size for in-content pages]. r=jorgk
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 57.0
You need to log in before you can comment on or make changes to this bug.