1400357 - browser/base/content/test/performance/browser_startup_images.js fails in hdpi mode on Windows 10

Status: RESOLVED FIXED

(Firefox :: Theme, defect, P3)

Description

[Andrew Halberstadt [:ahal]]

https://treeherder.mozilla.org/logviewer.html#?job_id=131089399&repo=try&lineNumber=4303

10:02:55     INFO -  101 INFO TEST-START | browser/base/content/test/performance/browser_startup_images.js
10:02:55     INFO -  TEST-INFO | started process screenshot
10:02:55     INFO -  TEST-INFO | screenshot: exit 0
10:02:55     INFO -  Buffered messages logged at 10:02:55
10:02:55     INFO -  102 INFO Entering test bound
10:02:55     INFO -  103 INFO TEST-FAIL | browser/base/content/test/performance/browser_startup_images.js | Whitelisted image chrome://global/skin/icons/resizer.png should not have been shown. -
10:02:55     INFO -  104 INFO TEST-PASS | browser/base/content/test/performance/browser_startup_images.js | Loaded image chrome://browser/skin/window-controls/minimize.svg should have been shown. -
10:02:55     INFO -  Buffered messages finished
10:02:55    ERROR -  105 INFO TEST-UNEXPECTED-FAIL | browser/base/content/test/performance/browser_startup_images.js | Loaded image chrome://browser/skin/window-controls/maximize.svg should have been shown. -

This was discovered while migrating tests from Windows 8 -> Windows 10 in bug 1397229. Since this was a newly added test and it also has some problems on Windows 7, it will be disabled on this platform (as part of bug 1397229). This bug will track fixing and re-enabling it.

Comment 2

[Johann Hofmann [:johannh]]

Attachment: Bug 1400357 - Whitelist maximize.svg in browser_startup_images.

There have been changes to our Windows infrastructure that cause the
window to be maximized when running tests so the maximize.svg/restore.svg
combination will show restore instead of maximize, though maximize is
still loaded. I think it could be prevented by trying to set the sizemode
attribute a little earlier or not defaulting to maximize in the stylesheet,
but I don't think that's a necessary optimization at this point. We can
just whitelist it.

I also set the intermittentShown flag in case the Windows machines go back
to non-maximized windows.

Review commit: https://reviewboard.mozilla.org/r/182588/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/182588/

Comment 3

[Johann Hofmann [:johannh]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=07b8896a8f3be39706b80c407193aea0c8e2cf4c

Comment 4

[Johann Hofmann [:johannh]]

Comment on attachment 8911092 [details]
Bug 1400357 - Whitelist maximize.svg in browser_startup_images.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/182588/diff/1-2/

Comment 5

[Johann Hofmann [:johannh]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a2a8d07ec9090e709a3b44fac04fda0b1a0a86a4

Comment 6

[Florian Quèze [:florian]]

(In reply to Johann Hofmann [:johannh] from comment #2)

> I also set the intermittentShown flag in case the Windows machines go back
> to non-maximized windows.

Should this be a comment in the test file?

Comment 7

[Florian Quèze [:florian]]

Comment on attachment 8911092 [details]
Bug 1400357 - Whitelist maximize.svg in browser_startup_images.

https://reviewboard.mozilla.org/r/182588/#review187860

Thanks!

Comment 8

[Joel Maher ( :jmaher ) (UTC -8)]

thanks for picking this up and getting a solution so quickly!

Comment 9

[Johann Hofmann [:johannh]]

Comment on attachment 8911092 [details]
Bug 1400357 - Whitelist maximize.svg in browser_startup_images.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/182588/diff/2-3/

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/43983cf4138e
Whitelist maximize.svg in browser_startup_images. r=florian

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/43983cf4138e

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/00b34310a5c5