1400372 - Fix service worker updates when importScripts() redirects

Status: RESOLVED FIXED

(Core :: DOM: Service Workers, enhancement, P2)

Description

[Ben Kelly [:bkelly, not reviewing]]

+++ This bug was initially created as a clone of Bug #1398484 +++

There is another bogus assertion like in bug 1398484 that assumes importScripts() cannot redirect.  This is in SW update code:

http://searchfox.org/mozilla-central/source/dom/workers/ServiceWorkerScriptCache.cpp#853

We should fix this and also make sure we have test coverage.

Comment 1

[Ben Kelly [:bkelly, not reviewing]]

Actually, it seems we don't allow redirects in importScripts() during the update process.  I think this just fell through the cracks when we added importScripts() update checking.

Comment 2

[Ben Kelly [:bkelly, not reviewing]]

Attachment: P1 Support redirected importScripts() when updating a service worker script. r=hopang

Ho-Pang, there are two fixes here:

1. We loosen the assertion like in bug 1398484.
2. We also need to remove the redirect limitation for non-main scripts.

Comment 3

[Ben Kelly [:bkelly, not reviewing]]

Attachment: P2 Add a WPT test that verifies a redirecting importScripts() can trigger an update. r=hopang

This adds another WPT test to verify we can update a service worker when a redirected importScripts() changes.  Without the P1 patch this test times out.  With the P1 patch this test passes.

Comment 4

[Ben Kelly [:bkelly, not reviewing]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a2c82750b237a619596d5a8f417ecd317f37bd1d

Comment 5

[Ben Hsu [:HoPang]]

Comment on attachment 8908782 [details] [diff] [review]
P1 Support redirected importScripts() when updating a service worker script. r=hopang

Review of attachment 8908782 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM

Comment 6

[Ben Hsu [:HoPang]]

Comment on attachment 8908791 [details] [diff] [review]
P2 Add a WPT test that verifies a redirecting importScripts() can trigger an update. r=hopang

Review of attachment 8908791 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, thanks!

Comment 7

[Ben Kelly [:bkelly, not reviewing]]

Pulsebot is resting...

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/5fc997003df2136894c118afab0854936a54da4c
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/bb67d7dc1ff22748e0e0dc845a58f387e6f8193d

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/5fc997003df2
https://hg.mozilla.org/mozilla-central/rev/bb67d7dc1ff2