warning: expression with side effects has no effect in an unevaluated context in nsCycleCollector.cpp

RESOLVED FIXED in Firefox 57

Status

()

RESOLVED FIXED
a year ago
a year ago

People

(Reporter: mccr8, Assigned: mccr8)

Tracking

(Blocks: 1 bug)

unspecified
mozilla57
Points:
---

Firefox Tracking Flags

(firefox57 fixed)

Details

Attachments

(1 attachment)

Build warning on this line:
MOZ_RELEASE_ASSERT(count++ < 2);

The fix is just to do the increment after the assert.
Comment hidden (mozreview-request)

Comment 3

a year ago
mozreview-review
Comment on attachment 8909381 [details]
Bug 1400374 - Fix compiler warning in FixGrayBits.

https://reviewboard.mozilla.org/r/180390/#review186124
Attachment #8909381 - Flags: review?(bugs) → review+

Comment 4

a year ago
Pushed by amccreight@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fa80123d276e
Fix compiler warning in FixGrayBits. r=smaug
https://hg.mozilla.org/mozilla-central/rev/fa80123d276e
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.