1400379 - No badge and misaligned labels in about:addons

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect, P5)

Description

[Oriol Brufau [:Oriol]]

1. Go to https://addons.mozilla.org/en-US/firefox/addon/ublock-origin/versions/
2. Install the 2nd version
3. Set automatic updates of uBlock to Off
4. Check for updates

Result: An "Available Updates" category appears at the left.
Expected: it should have a badge with the number of available updates.

Comment 1

[Valentina Claudia Ona]

Hi Oriol! 55 and 56 versions are unaffected, right?

Comment 2

[Oriol Brufau [:Oriol]]

Yes, this was caused by bug 1393099, which only affected Firefox 57.

Comment 4

[Mark Striemer [:mstriemer]]

Attachment: Bug 1400379 - Backed out changeset e0fe9ab6917b

Review commit: https://reviewboard.mozilla.org/r/181580/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/181580/

Comment 5

[Mark Striemer [:mstriemer]]

Attachment: Bug 1400379 - Crop category labels in about: pages

Review commit: https://reviewboard.mozilla.org/r/181582/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/181582/

Comment 6

[Mark Striemer [:mstriemer]]

Attachment: cropped-label.png

Duped bug 1400813 onto this one since they're both for regressions from bug 1393099. See 1393099 comment 22 for more info on the misaligned label.

The best solution I can come up with for now is to crop the label. The wrapping is overly aggressive and causes "Available Updates" to be on two lines in English when it looks like it should fit. Also the code expects "badgeCount" to be set on the element which would make putting the badge back in with wrapping the text a bit complicated.

It might be nice to make the sidebar a bit wider, if that's acceptable I can update my patch.

Comment 7

[Robert Helmer [:rhelmer]]

Comment on attachment 8910104 [details]
Bug 1400379 - Backed out changeset e0fe9ab6917b

https://reviewboard.mozilla.org/r/181580/#review187392

Comment 8

[Robert Helmer [:rhelmer]]

Comment on attachment 8910105 [details]
Bug 1400379 - Crop category labels in about: pages

https://reviewboard.mozilla.org/r/181582/#review187394

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a16272acfb61
Backed out changeset e0fe9ab6917b r=rhelmer
https://hg.mozilla.org/integration/autoland/rev/78a56e071468
Crop category labels in about: pages r=rhelmer

Comment 10

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/a16272acfb61
https://hg.mozilla.org/mozilla-central/rev/78a56e071468

Comment 11

[Mark Striemer [:mstriemer]]

Comment on attachment 8910104 [details]
Bug 1400379 - Backed out changeset e0fe9ab6917b

Approval Request Comment
[Feature/Bug causing the regression]: This is a regression from bug 1393099.
[User impact if declined]: This results in unnecessary wrapping of text and the removal of the number of updates that are available from the label.
[Is this code covered by automated tests?]: There are no automated tests for how this text wraps. Testing was done manually and the regression was noted in bug 1393099 comment 22 and here.
[Has the fix been verified in Nightly?]: I have manually verified this in Nightly.
[Needs manual test from QE? If yes, steps to reproduce]: See comment 0.
[List of other uplifts needed for the feature/fix]: The second patch in this bug (f471d18f98131c18fc4569edc88e45ec73d9dc8d).
[Is the change risky?]: This is low risk change.
[Why is the change risky/not risky?]: It is backing out the more complicated changeset and replacing is with a XUL change to trim the string with an ellipsis instead.
[String changes made/needed]: none

Comment 12

[Mark Striemer [:mstriemer]]

Comment on attachment 8910105 [details]
Bug 1400379 - Crop category labels in about: pages

See above.

Comment 13

[Sylvestre Ledru [:Sylvestre]]

Mark, Andy marked 57 as wontfix and P5. Why should we take the uplift? Thanks

Comment 14

[Andy McKay]

I was working on the assumption that it wasn't important to uplift. As it turns out its so small that it might  a good regression to fix since it affects the user interface that some situations might trigger. I'll take your recommendation either way Sylvestre.

Comment 15

[marius.santa]

Attachment: number of updates.PNG

This bug is verified on Firefox 58.0a1 (20170927100120) under Windows 10 64-bit and Mac OS X 10.12.3.

The label on the "Available Updates" section is displayed with the correct number of updates.

Please see the attached screenshot.

Comment 16

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8910104 [details]
Bug 1400379 - Backed out changeset e0fe9ab6917b

Polish the l&f, taking it.
Should be in 57b4. GTB later today.

Comment 17

[Ryan VanderMeulen [:RyanVM]]

FYI, marking bugs you want uplifted as "wontfix" is a really good way for them to get overlooked later.

Comment 18

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/f2ce863c2b63
https://hg.mozilla.org/releases/mozilla-beta/rev/54e415e48407

Comment 19

[marius.santa]

Attachment: updates badge.PNG

This bug is verified on Firefox 57.0b4 (20170928180207) under Windows 10 64-bit and Mac OS X 10.12.3.

The label on the "Available Updates" section is displayed with the correct number of updates.

Please see the attached screenshot.