Closed Bug 1400386 Opened 2 years ago Closed 2 years ago

Fix or disable test layout/reftests/font-face/font-display-1.html

Categories

(Core :: CSS Parsing and Computation, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
mozilla57
Tracking Status
firefox57 + fixed

People

(Reporter: michal, Assigned: bradwerth)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

This test intermittently fails (bug 1238222) and there is a spike when we enable RCWN. For this reason RCWN was backed out several times (see bug 1392841 comments 19 and 33). This test needs to be either fixed or disabled.

[Tracking Requested - why for this release]:
It blocks RCWN which is targeted for 57 release.
Flags: needinfo?(bwerth)
I don't have insights into how this test fails or how to fix it. I defer to Jonathan Kew's analysis in Bug 1238222 comment 49. So I've provided a patch to disable the test.
Assignee: nobody → bwerth
Flags: needinfo?(bwerth)
Attachment #8908847 - Flags: review?(aryx.bugmail)
Comment on attachment 8908847 [details]
Bug 1400386: Skip reftest layout/reftests/font-face/font-display-1.html for being intermittent.

https://reviewboard.mozilla.org/r/180458/#review185706

::: layout/reftests/font-face/reftest.list:184
(Diff revision 1)
>  HTTP(..) == reflow-sanity-delay-1b.html reflow-sanity-1-ref.html
>  HTTP(..) == reflow-sanity-delay-1c.html reflow-sanity-1-ref.html
>  HTTP(..) == reflow-sanity-delay-1-metrics.html reflow-sanity-1-ref.html
>  
>  # font-display
> -pref(layout.css.font-display.enabled,true) HTTP(..) == font-display-1.html font-display-1-ref.html # normal font load (~500ms)
> +skip pref(layout.css.font-display.enabled,true) HTTP(..) == font-display-1.html font-display-1-ref.html # normal font load (~500ms)

All failures are on Linux and all except one on 32-bit: https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1238222
So keeping test coverage on Linux x64 should cause no issues. Please use
skip-if(/^Linux\x20i686/.test(http.oscpu))
similar to https://dxr.mozilla.org/mozilla-central/rev/f9a5e9ed62103c84e4cde915f4d08f1ce71be83e/image/test/reftest/downscaling/reftest.list#90
Attachment #8908847 - Flags: review?(aryx.bugmail) → review-
Comment on attachment 8908847 [details]
Bug 1400386: Skip reftest layout/reftests/font-face/font-display-1.html for being intermittent.

https://reviewboard.mozilla.org/r/180458/#review186080

Thank you for the change.
Attachment #8908847 - Flags: review?(aryx.bugmail) → review+
Pushed by bwerth@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/203c1f909ae0
Skip reftest layout/reftests/font-face/font-display-1.html for being intermittent. r=aryx
https://hg.mozilla.org/mozilla-central/rev/203c1f909ae0
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Blocks: 1403254
You need to log in before you can comment on or make changes to this bug.