1400398 - Non-image extracted from getpocket trending for page image url

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: Activity Stream, enhancement, P5)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

(In reply to Michael Comella (:mcomella) from comment bug 1400397 #0)
> Chenxia discovered https://getpocket.com/explore/trending shows a blank
> image in highlights. It turns out our override image url is
> https://getpocket.com/explore/trending, which explains why there is no image
> there. :P
> 
> There are two issues here:
> 1) If we fail to load the override image url, we should fall back on the
> pageURL.
> 2) Why are we extracting https://getpocket.com/explore/trending as an image?

Let's deal with #2 here.

---

Adding to triage because this doesn't seem important.

Comment 1

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

#1 is bug 1400397.

Comment 2

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

The image url comes from the PageMetadata stored in the DB. This is passed to Java with a message from WebsiteMetadata.jsm [1]. Here are the tags we use [2]:

      ['meta[property="og:image:secure_url"]', node => node.element.getAttribute("content")],
      ['meta[property="og:image:url"]', node => node.element.getAttribute("content")],
      ['meta[property="og:image"]', node => node.element.getAttribute("content")],
      ['meta[property="twitter:image"]', node => node.element.getAttribute("content")],
      ['meta[name="thumbnail"]', node => node.element.getAttribute("content")],

Looking at https://getpocket.com/explore/trending, I see:
- <meta property="og:image" content="" ...>
- <meta name="twitter:image" content="" ...>

I wonder if the given value is empty, for some reason we replace it with the site url.

Other notes:
- On this site, "twitter:image" is under name, not property but our script only looks for property.

[1]: http://searchfox.org/mozilla-central/rev/184f0c7888dd6abb32235377693b7d1fc0b75ac1/mobile/android/modules/WebsiteMetadata.jsm#24
[2]: http://searchfox.org/mozilla-central/rev/184f0c7888dd6abb32235377693b7d1fc0b75ac1/mobile/android/modules/WebsiteMetadata.jsm#128

Comment 3

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

We have a default image already for highlights so it's not important for this sprint.

Comment 4

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

[eng triage recommendation] P3: users can see this happening if the Pocket/highlight images do not appear instantly, but instead there is a pause and they pop in. The images will be favicons rather than higher quality images from the page content. We've only seen one bad url so we'll deprioritize this unless we start to see many issues like the above.

Comment 5

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

[triage] Agreed. ^

Comment 6

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

All open Activity Stream bugs are moving from the whiteboard tag, "[mobileAS]", to the Firefox for Android component, "Activity Stream", so that I can keep better track of these bugs as the new triage owner; I will send out an email shortly with additional details, caveats, etc.

Comment 7

[Firefox Bug Husbandry Bot]

Re-triaging per https://bugzilla.mozilla.org/show_bug.cgi?id=1473195

Needinfo :susheel if you think this bug should be re-triaged.

Comment 8

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.