1400411 - Stop using a DrawTargetSkia inside of TextDrawTarget

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement, P1)

Description

[Jeff Muizelaar [:jrmuizel]]

DrawTargetSkia::Init accounts for 26% of nsDisplayText::nsDisplayText time.

Gankro has a patch to fix this.

Comment 1

[Jeff Muizelaar [:jrmuizel]]

Another 4.8% of the total paint time is spent deleting the DrawTargetSkia's. Fixing this should give us reasonably good performance improvement and is pretty low hanging fruit.

Comment 2

[Aria Beingessner [:Gankra]]

Attachment: Bug 1400411 - stop mocking most of DrawTarget.

Also fixes a bad debug assertion

Review commit: https://reviewboard.mozilla.org/r/180608/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/180608/

Comment 3

[Aria Beingessner [:Gankra]]

I tried to test this patch out as best I could but webrendest gecko is pretty unstable right now.

Comment 4

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8908997 [details]
Bug 1400411 - stop mocking most of DrawTarget.

https://reviewboard.mozilla.org/r/180608/#review185794

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/8a0b8dfa2d7d

Comment 6

[Aria Beingessner [:Gankra]]

This is causing us to crash on tofu and SVG fonts. We never handled them properly but crashing is a lot worse.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Backed out at Alexis' request.
https://hg.mozilla.org/integration/mozilla-inbound/rev/7fba2073e87027ba4d61196df519f5b32560857d

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Merged backout https://hg.mozilla.org/mozilla-central/rev/7fba2073e870

Comment 9

[Aria Beingessner [:Gankra]]

I have a new patch for this based on my patches in Bug 1400382 that seems to work well. Will post when that lands.

Comment 10

[Aria Beingessner [:Gankra]]

Attachment: Bug 1400411 - text-layers: fallback if SVG fonts or tofu is found.

Review commit: https://reviewboard.mozilla.org/r/183242/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/183242/

Comment 11

[Aria Beingessner [:Gankra]]

Comment on attachment 8908997 [details]
Bug 1400411 - stop mocking most of DrawTarget.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/180608/diff/1-2/

Comment 12

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8911815 [details]
Bug 1400411 - text-layers: fallback if SVG fonts or tofu is found.

https://reviewboard.mozilla.org/r/183242/#review188400

Comment 13

[Aria Beingessner [:Gankra]]

Note to checkin people, this is based off of Bug 1400382, which is still inbound.

Comment 14

[Aria Beingessner [:Gankra]]

Hitting a debug assert, investigating.

Comment 15

[Aria Beingessner [:Gankra]]

Ah, it was just Bug 1402004. Should be good.

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0caa5a0f9ccb
text-layers: fallback if SVG fonts or tofu is found. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/0d7f60023a14
stop mocking most of DrawTarget. r=jrmuizel

Comment 17

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/0caa5a0f9ccb
https://hg.mozilla.org/mozilla-central/rev/0d7f60023a14