1400473 - Update talos test tpaint.html to comply with new toplevel data: URI navigation policy

Status: RESOLVED FIXED

(Core :: DOM: Security, defect, P1)

Comment 1

[Christoph Kerschbaumer [:ckerschb]]

Now we are back to where we were for Bug 1393350, which then caused the performance regression and we changed the test back to using a data: URI within Bug 1393742.

Comment 2

[Christoph Kerschbaumer [:ckerschb]]

Smaug, Joel, the pref |security.data_uri.block_toplevel_data_uri_navigations| blocks loading of the data: URI here [1]. We already had a similar problem within Bug 1393350, which we fixed by loading the data: URI from an external file. In turn, this change caused a performance regression so we changed it back to using a data: URI and a postmessage handler within Bug 1393742.

The problem here is that the pref "security.data_uri.block_toplevel_data_uri_navigations" blocks loading of the data: URI in the toplevel window entirely. Hence, I see two options:

a) We rewrite tpaint.html to load the data: URI from an external file and use the new perf number as the new baseline.
b) We somehow manage to explicitly set that pref before loading the test. I looked at other talos tests but couldn't really find a way to do that.

What do you think?

[1] https://dxr.mozilla.org/mozilla-central/source/testing/talos/talos/tests/tpaint/tpaint.html#78

Comment 3

[Christoph Kerschbaumer [:ckerschb]]

Attachment: bug_1400473_update_tpaint.patch

I don't see a way to actually flip that pref :-(

Here is a patch for loading the data: URI from an external file in case we decide to go down that route and someone already wants to r+ that change.

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

I think for now setting the pref somehow sounds like the best option. Otherwise tpaint starts to measure different things.

But I'm not against a new file either. We just need to understand the baseline for the test result changes significantly.
I think this is up to jmaher.

Comment 5

[Christoph Kerschbaumer [:ckerschb]]

Attachment: bug_1400473_update_tpaint.patch

Joel, as discussed on IRC, it's best if we just flip the pref explicitly within testing/talos/talos/test.py. Thanks for your help with that!

Comment 6

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8909292 [details] [diff] [review]
bug_1400473_update_tpaint.patch

Review of attachment 8909292 [details] [diff] [review]:
-----------------------------------------------------------------

glad it is this simple!

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ff9e6251cd55
Update talos test tpaint.html to comply with new toplevel data: URI navigation policy. r=jmaher

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/ff9e6251cd55