1400556 - Bookmarks on tabbar are displaced while tabs are moved

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, defect, P1)

Description

[[:philipp]]

Attachment: screencapture

str in a new profile:
- place the bookmarks toolbar items on the tabbar
- grab and move a tab

while dragging a tab around the bookmark items are no longer centred in the toolbar, but get shifted downwards.

this regressed with bug 450915.

Comment 1

[Oriol Brufau [:Oriol]]

BTW, this also happens with icons like "Insert Build ID into Textbox" of the legacy Nightly Tester Tools add-on.

Comment 2

[:Gijs (he/him)]

(In reply to Oriol Brufau [:Oriol] from comment #1)
> BTW, this also happens with icons like "Insert Build ID into Textbox" of the
> legacy Nightly Tester Tools add-on.

We no longer support legacy add-ons.

Comment 3

[:Gijs (he/him)]

Attachment: Bug 1400556 - apply padding to the tabs toolbar too to avoid other items moving when dragging tabs,

Review commit: https://reviewboard.mozilla.org/r/180624/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/180624/

Comment 4

[Johann Hofmann [:johannh]]

Comment on attachment 8909024 [details]
Bug 1400556 - apply padding to the tabs toolbar too to avoid other items moving when dragging tabs,

https://reviewboard.mozilla.org/r/180624/#review185762

Makes sense, thanks!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/af7271ca580b
apply padding to the tabs toolbar too to avoid other items moving when dragging tabs, r=johannh

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/af7271ca580b

Comment 7

[Valentina Claudia Ona]

I verify this issue using Nightly 58.0a1 and Firefox Beta 57.0b3
Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:58.0) Gecko/20100101 Firefox/58.0
Build ID 20170926220106
on Windows 10 x64, Mac OS X 10.9, Windows 7 x64.
I will mark this as verified fixed.