1400566 - JSDcov code coverage busted: ([Exception... "Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [IJSDebugger.addClass]" nsresult: "0x80070057 (NS_ERROR_ILLEGAL_VALUE)"

Status: RESOLVED FIXED

(Testing :: Code Coverage, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

See bug 1381961 and bug 1400489 a shared global for JSMs.

First run with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&revision=6c1b45e7e94dbf343813eda03f1fd0b3259b59b1&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable

Example log: https://treeherder.mozilla.org/logviewer.html#?job_id=131454517&repo=mozilla-central

[task 2017-09-16T10:56:13.244Z] 10:56:13    ERROR -  GECKO(1296) | TEST-UNEXPECTED-FAIL: setup.js | error parsing http://mochi.test:8888/tests.json ([Exception... "Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [IJSDebugger.addClass]"  nsresult: "0x80070057 (NS_ERROR_ILLEGAL_VALUE)"  location: "JS frame :: resource://gre/modules/jsdebugger.jsm :: addDebuggerToGlobal :: line 23"  data: no])
[task 2017-09-16T10:56:13.246Z] 10:56:13     INFO -  GECKO(1296) | JavaScript error: resource://gre/modules/jsdebugger.jsm, line 23: NS_ERROR_ILLEGAL_VALUE: Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [IJSDebugger.addClass]
[task 2017-09-16T11:12:53.277Z] 11:12:53     INFO - Automation Error: mozprocess timed out after 1000 seconds running ['/builds/worker/workspace/build/venv/bin/python', '-u', '/builds/worker/workspace/build/tests/mochitest/runtests.py', '--disable-e10s', '--total-chunks', '10', '--this-chunk', '8', '--jscov-dir-prefix=/builds/worker/workspace/build/blobber_upload_dir', '--appname=/builds/worker/workspace/build/application/firefox/firefox', '--utility-path=tests/bin', '--extra-profile-file=tests/bin/plugins', '--symbols-path=https://queue.taskcluster.net/v1/task/GzuKtY4NRAiee3sjJkwfpQ/artifacts/public/build/target.crashreporter-symbols.zip', '--certificate-path=tests/certs', '--setpref=webgl.force-enabled=true', '--quiet', '--log-raw=/builds/worker/workspace/build/blobber_upload_dir/plain-chunked-coverage_raw.log', '--log-errorsummary=/builds/worker/workspace/build/blobber_upload_dir/plain-chunked-coverage_errorsummary.log', '--use-test-media-devices', '--screenshot-on-fail', '--cleanup-crashes', '--marionette-startup-timeout=180', '--work-path=/builds/worker/workspace/build', '--chunk-by-dir=4', '--timeout=1200']

See https://dxr.mozilla.org/mozilla-central/rev/6be5c7d30d2def62a762ac187252eba626b23a92/js/ductwork/debugger/jsdebugger.jsm#23
> this.addDebuggerToGlobal = function addDebuggerToGlobal(global) {
>   init.addClass(global);
>   initPromiseDebugging(global);
> };

Comment 1

[Kris Maglione [:kmag]]

Looks like it needs to be updated to use getGlobalForObject

Comment 2

[Andrew McCreight [:mccr8]]

Are there any unit tests for CoverageUtils.jsm that I can run locally?

Comment 3

[Andrew McCreight [:mccr8]]

I haven't tested this, but it looks reasonable to me...

Comment 4

[Andrew McCreight [:mccr8]]

Attachment: Bug 1400566 - Explicitly get the global of |this| in CoverageUtils.jsm.

With shared JSM globals, |this| is an NSVO, not a global.

Review commit: https://reviewboard.mozilla.org/r/180628/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/180628/

Comment 5

[Andrew McCreight [:mccr8]]

Oh, I see, this isn't run by default, which is why my -p all -u all runs didn't find this.

Here's a try run to try to confirm that it works:
  https://treeherder.mozilla.org/#/jobs?repo=try&revision=02d13d126ab2fcfb1c27b73b535fb309b1a543fd

Comment 6

[Andrew McCreight [:mccr8]]

This patch is pretty trivial, so if somebody gets impatient, feel free to land this with r=bustage...

Comment 7

[Kris Maglione [:kmag]]

Comment on attachment 8909023 [details]
Bug 1400566 - Explicitly get the global of |this| in CoverageUtils.jsm.

https://reviewboard.mozilla.org/r/180628/#review185742

Comment 8

[Andrew McCreight [:mccr8]]

I guess I didn't set up the try run correctly, so we'll just see what happens when I land this.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/401477969d7c
Explicitly get the global of |this| in CoverageUtils.jsm. r=kmag

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/401477969d7c

Comment 11

[Greg Mierzwinski [:sparky]]

Thank you for taking care of this! :)

:mccr8, jsdcov and ccov only work with |mach try fuzzy -q 'linux64-jsdcov ...'| now after some changes from the windows taskcluster migration, IIRC. The documents haven't been updated to reflect this change yet, sorry about that.

Comment 12

[Intermittent Failures Robot]

188 failures in 1032 pushes (0.182 failures/push) were associated with this bug in the last 7 days. 

This is the #7 most frequent failure this week. 

** This failure happened more than 75 times this week! Resolving this bug is a very high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 1 week, the affected test(s) may be disabled. **   

Repository breakdown:
* mozilla-central: 188

Platform breakdown:
* linux64-jsdcov: 188

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1400566&startday=2017-09-11&endday=2017-09-17&tree=all

Comment 13

[Intermittent Failures Robot]

3 failures in 943 pushes (0.003 failures/push) were associated with this bug in the last 7 days.    

Repository breakdown:
* mozilla-central: 3

Platform breakdown:
* linux64-jsdcov: 3

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1400566&startday=2017-09-18&endday=2017-09-24&tree=all